Skip to content

Km/optional variables #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenmtb1 merged 3 commits into from
Jun 4, 2026
Merged

Km/optional variables #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
855f519
chore: make ATP addresses optional
koenmtb1 Jun 4, 2026
89515c1
fix: regex address check
koenmtb1 Jun 4, 2026
7434bad
Merge branch 'main' into km/optional-variables
koenmtb1 Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions atp-indexer/src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,20 @@ const configSchema = z.object({
ATP_FACTORY_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format'),
ATP_FACTORY_AUCTION_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format'),
// MATP/LATP factories aren't deployed in every environment (e.g.,
// testnet has only genesis + auction). Treat them as optional and
// gate their contract registration + handlers in ponder.config.ts /
// events/atp-factory so the indexer boots cleanly on lighter envs.
ATP_FACTORY_MATP_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format').optional(),
ATP_FACTORY_LATP_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format').optional(),
// testnet has only genesis + auction). The deploy pipeline propagates
// unset GitHub Actions vars → terraform vars → ECS env as the empty
// string `""`, NOT as undefined, so we preprocess `""` → undefined
// before the regex check; `.optional()` then accepts undefined.
// ponder.config.ts falls back to the zero address when these resolve
// to undefined, see comments there.
ATP_FACTORY_MATP_ADDRESS: z.preprocess(
(val) => (val === '' ? undefined : val),
z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format').optional(),
),
ATP_FACTORY_LATP_ADDRESS: z.preprocess(
(val) => (val === '' ? undefined : val),
z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format').optional(),
),
STAKING_REGISTRY_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format'),
REGISTRY_ADDRESS: z.string().regex(/^0x[a-fA-F0-9]{40}$/, 'Invalid Ethereum address format'),

Expand Down
Loading