fix(ci3): tolerate unavailable redis in log writes#24209
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis_setexzdrain stdin and return success when Redis is unavailable.docker psoutput from the local dashboard probe when Docker is not reachable.Root Cause
The linked
barretenberg-claudeActions run is not readable from this public-mode session, but the same nightly debug launcher failure is reproducible from the current CI helper: withCI_REDIS_AVAILABLE=0,echo "CI booting..." | redis_setexz ...exits underpipefailwith SIGPIPE beforebootstrap_ec2can launch the debug build.That means the nightly can report as a barretenberg debug build failure even though no C++ build or test has started. The helper now consumes stdin when Redis is intentionally unavailable, so callers that use
redis_setexzfor best-effort log publication do not abort.Verification
CI=1 CI_REDIS_AVAILABLE=0 bash -lc 'set -euo pipefail; source ci3/source; echo "CI booting..." | redis_setexz test-key 1; echo after'ci3/tests/source_redis_testbash -n ci3/source_redis ci3/tests/source_redis_test .github/ci3.sh ci.sh ci3/bootstrap_ec2Created by claudebox · group:
slackbot