fix(txe): correct AVM oracle registry types for call and success_copy#24203
Open
nchamo wants to merge 3 commits into
Open
fix(txe): correct AVM oracle registry types for call and success_copy#24203nchamo wants to merge 3 commits into
nchamo wants to merge 3 commits into
Conversation
nchamo
commented
Jun 19, 2026
| call(l2Gas: number, daGas: number, address: AztecAddress, argsLength: number, args: Fr[]): Promise<Fr[]>; | ||
| staticCall(l2Gas: number, daGas: number, address: AztecAddress, argsLength: number, args: Fr[]): Promise<Fr[]>; | ||
| successCopy(): Promise<Fr>; | ||
| call(l2Gas: number, daGas: number, address: AztecAddress, argsLength: number, args: Fr[]): Promise<void>; |
Contributor
Author
There was a problem hiding this comment.
These were incorrect all along, they just weren't being used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aztec_avm_callandaztec_avm_staticCallregistry entries: removed incorrectreturnType: ARRAY(FIELD)(the Noir oracles return void).aztec_avm_successCopyregistry entry: changedreturnType: FIELDtoreturnType: BOOLto match the Noir oracle'sboolreturn.call_opcode,call_static_opcode, andsuccess_copy_opcodefrom thegenerate_oracle_tests_excludinglist so they now get serialization roundtrip tests.