Fix Goods bulk visibility ignoring tag filters - #1849
Merged
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Azgaar
added a commit
that referenced
this pull request
Sep 11, 2026
* Fix state creation and province recolouring refresh (#1848) * fix: refresh state creation and province recolouring * fix: preserve hidden layers when refreshing state edits * fix: respect goods tag filters in bulk visibility changes (#1849) * fix: add name field to the marker editor (#1851) Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * investigation doc * mamory leaks fixes --------- Co-authored-by: barrulus <b@rry.im> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Azgaar
added a commit
that referenced
this pull request
Sep 16, 2026
* Resolving Memory leaks (#1852) * Fix state creation and province recolouring refresh (#1848) * fix: refresh state creation and province recolouring * fix: preserve hidden layers when refreshing state edits * fix: respect goods tag filters in bulk visibility changes (#1849) * fix: add name field to the marker editor (#1851) Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * investigation doc * mamory leaks fixes --------- Co-authored-by: barrulus <b@rry.im> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * fix: skip removed states when vassals copy suzerain relations (#1854) A removed state is stored as {i, removed: true} with no diplomacy array. generateDiplomacy skips removed states in its outer loops, but the vassal-copy loops iterate every index, so the first vassal processed throws a TypeError on the removed state's missing diplomacy. Generation aborts partway, leaving every later row at the "x" placeholder, which the editor now shows as "Invalid" and can no longer regenerate. * Omnibar (#1850) * init * omnibar * entities and commands * goods * style and export commands * seach button in menu * cleanup * cleanup * fix tests * fixes * fixes * fixes * Azgaar Assistant trigger * organize * cleanup * Wrap tool (#1831) * init * wrap tool * coastline - local roughness --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * fix: stop an empty legend redrawing as an "undefined" row (#1844) * fix: stop an empty legend redrawing as an "undefined" row A legend box with no items - the Zones editor with everything filtered out - stores an empty string in its data attribute. Splitting that on "|" yields one blank row rather than none, so the next redraw drew a swatch with fill "undefined" and the label "undefined" under the title. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDnWHpXXkGnY61DPMSL9Ms * feat: report an empty legend instead of drawing an empty box Toggling a legend for a list with nothing in it drew a box holding only its title. Each editor now reports it the way the overviews do and draws nothing, so the feedback arrives when the button is pressed rather than later, when a style change happens to redraw the box. The parse fix stays underneath: a map saved before this can already hold an empty box, and that still has to redraw as empty rather than as a blank row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDnWHpXXkGnY61DPMSL9Ms --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * Remove vertex editing from the Lakes Editor (#1858) Lake shores are reshaped only with the Wrap tool now; the per-vertex drag handles and their #debug overlay are gone from the Lake editor. Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * Features overview (#1859) * init * improve the ui * ocean hightlight * coastline for features * coastline editor tweaks * styling * update docs * feature names * ocean name * fixes * fixes * fix * fixes * dialog state - reset button (#1861) * performance settings (#1862) * Ink style (#1864) * first try * Ocean embellishment * haching * lakes * cinderwood start * cleanup * icons * icons update * coastal bands * frostbite preset * fix * fixes * optimization * cleanup * fixes * update notes * fix * bring old update posts for better new updates (more human-created data) * fix stale wiki * fix test * fix: refill empty burg icon and anchor style records from the saved map (#1855) Pre-v1.150 main.js initialised the legacy style record as burgIcons: {}, anchors: {}, and the v1.150 migration took an empty object as a present record: it stored it empty and skipped the svg harvest that still held the group sizes. Nothing could refill it afterwards: the renderer emitted no font-size, the style editor showed 1 and dropped every edit to a missing group, and ensureBurgGroupStyles had no template to copy. The migration now harvests an empty record from the svg, load refills an already-migrated empty record the same way and seeds any burg group without a style entry, and ensureBurgGroupStyles falls back to the shipped defaults when a record has no group to copy. * drainage (#1868) * fixes * fix: preserve cascading column sorting in overview tables (#1869) * fix: use available stock when planning manufacturing chains (#1867) * fix: count remaining manufacturing work from available stock * style: trim production comments and reuse record guard * test: cover freighter production with twenty engines * fix doc * fix tests --------- Co-authored-by: barrulus <b@rry.im> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Eric Sullivan <56692984+esullivan9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Goods editor's bulk visibility checkbox now affects all goods matching the active tag filter across pages, preserving unrelated goods. The checkbox reflects the filtered selection and is disabled for an empty result set; the footer's map-wide displayed count updates after bulk changes. Clearing the filter restores the action to the whole catalogue.
Reuses the existing table's filtered data and visible-count helper. The fix is documented in the changelog only.
Fixes #1783.
Validation:
3da6d84a.Tests extend the existing table-actions spec and use the shared map-readiness helper. The full E2E suite and map corpus were not run.