Fix heading/camera mode button not responding on launcher (#56)#60
Merged
Conversation
The camera-panel buttons (mode/heading cycle, zoom, tilt) were bound on `click`, which the NativeWebView launcher (touch) doesn't fire reliably — so tapping the heading-mode button did nothing on the launcher build while it worked in a browser. Bind them on `pointerdown` instead (the same event the rest of the touch UI uses); the campad container already stops propagation so this doesn't pan the map. Fixes #56. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56 — tapping the heading/camera-mode button does nothing on the launcher (NativeWebView) build, though it works in a browser.
Cause
The camera-panel buttons (mode/heading cycle, zoom, tilt) were bound on
click. The NativeWebView launcher's touch handling doesn't reliably fireclick, so the taps were dropped. The rest of the touch UI (bottom nav, sim bar, dialogs) usespointerdown.Fix
Bind the five
#cp-*camera buttons onpointerdowninstead ofclick. The#campadcontainer already callsstopPropagationon pointerdown, so this doesn't pan the map. Also fixes the zoom/tilt buttons, which had the same latent bug.Verification
JS syntax-checked. Needs device verification on the launcher build — the whole bug is launcher-touch-specific and can't be reproduced in a browser. Tapping the "M" button should cycle Heading-Up → North-Up → Map → Center.
v26.6.70.
🤖 Generated with Claude Code