fix: SG-43097: Thumbnail gen psutil refactor#1281
Merged
bernie-laberge merged 7 commits intoJun 9, 2026
Merged
Conversation
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
deltag0
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
compaga
changed the title
deltag0
changed the title
Signed-off-by: deltag0 <victor.terme@autodesk.com>
Signed-off-by: deltag0 <victor.terme@autodesk.com>
bernie-laberge
approved these changes
Jun 2, 2026
bernie-laberge
left a comment
bernie-laberge
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Good job @deltag0 !
Signed-off-by: deltag0 <victor.terme@autodesk.com>
bernie-laberge
changed the title
This reverts commit e0767d9. Signed-off-by: deltag0 <victor.terme@autodesk.com>
deltag0
force-pushed
the
thumbnail-gen-psutil-refactor
branch
from
686cbf3 to
01d425d
Compare
bernie-laberge
removed
the
PR: Acknowledged
bernie-laberge
merged commit 5055423
into
AcademySoftwareFoundation:main
16 checks passed
deltag0
added a commit
to deltag0/OpenRV
that referenced
this pull request
Jun 29, 2026
…on#1281) ### fix: Refactor Session Manager thumbnail generation to use psutil ### Summarize your change. - Remove sending manual signals to start/stop process - Use psutil to start/stop process ### Describe the reason for the change. - More modern and standard way to start/stop processes ### Describe what you have tested and on which operating system. - Tested on CY2025 on Mac ### Add a list of changes, and note any that might need special attention during the review. - Build works correctly on all the OSes --------- Signed-off-by: deltag0 <victor.terme@autodesk.com>
deltag0
added a commit
to deltag0/OpenRV
that referenced
this pull request
Jun 29, 2026
…on#1281) ### fix: Refactor Session Manager thumbnail generation to use psutil ### Summarize your change. - Remove sending manual signals to start/stop process - Use psutil to start/stop process ### Describe the reason for the change. - More modern and standard way to start/stop processes ### Describe what you have tested and on which operating system. - Tested on CY2025 on Mac ### Add a list of changes, and note any that might need special attention during the review. - Build works correctly on all the OSes --------- Signed-off-by: deltag0 <victor.terme@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Refactor Session Manager thumbnail generation to use psutil
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.