Fix ocioconvert invalid bidepth handling#2323
Open
zlrs1013 wants to merge 1 commit into
Open
Conversation
Signed-off-by: zial <zhenlai1013@gmail.com>
|
|
Author
|
I checked the failing Read the Docs build. It appears unrelated to this PR. The build failure appears to be related to a .readthedocs.yml config validation error for build.os, while this PR only changes src/apps/ocioconvert/main.cpp. |
doug-walker
requested changes
Jun 28, 2026
doug-walker
left a comment
doug-walker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution Zhen!
Yes, the ReadTheDocs issue is unrelated to your work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2110
This updates ocioconvert so an invalid --bitdepth value reports a normal CLI error and usage text instead of throwing an uncaught exception.
Verified with:
cmake --build build --target ocioconvert --config Release
.\build\src\apps\ocioconvert\Release\ocioconvert.exe --bitdepth 32 --view input.exr "ACES2065-1" output.exr "sRGB - Display" "ACES 2.0 - SDR 100 nits (Rec.709)"