feat: Updating newest MoranaApps version for generating JaCoCo report#175
Draft
tmikula-dev wants to merge 10 commits into
Draft
feat: Updating newest MoranaApps version for generating JaCoCo report#175tmikula-dev wants to merge 10 commits into
tmikula-dev wants to merge 10 commits into
Conversation
|
JaCoCo Coverage Report
Run 27826524106 · Event: |
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s JaCoCo coverage setup from custom in-repo SBT AutoPlugins to the official jacoco-method-filter-sbt plugin, and updates the GitHub Actions workflow to run coverage reporting with module-level grouping/thresholds.
Changes:
- Added
io.github.moranaapps:jacoco-method-filter-sbtSBT plugin and enabledJacocoFilterPluginin relevant modules. - Removed custom JaCoCo/JMF SBT plugin implementations and moved coverage command aliases into
.sbtrc. - Overhauled the
jacoco_check.ymlworkflow to (a) detect Scala changes, (b) run coverage, and (c) post grouped JaCoCo PR comments viaMoranaApps/jacoco-report.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
project/plugins.sbt |
Adds the official jacoco-method-filter-sbt plugin dependency. |
project/JacocoBaseKeysPlugin.scala |
Removes obsolete custom JaCoCo base keys plugin. |
project/FilteredJacocoAgentPlugin.scala |
Removes obsolete custom JaCoCo/JMF agent + reporting plugin implementation. |
build.sbt |
Switches modules to JacocoFilterPlugin and removes old custom JaCoCo wiring/aliases. |
api/src/main/scala/za/co/absa/loginsvc/rest/AuthManagerConfig.scala |
Cleans up an unused import. |
.sbtrc |
Adds SBT aliases for running JaCoCo per module and toggling participation. |
.github/workflows/jacoco_check.yml |
Updates CI coverage workflow (change detection, grouped thresholds, PR reporting). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+86
to
+88
| - name: Build and run tests with coverage | ||
| continue-on-error: true | ||
| run: sbt jacoco |
…on' into feature/166-implement-jmf-solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request overhauls the project's JaCoCo test coverage reporting setup, replacing custom SBT plugins with the official
jacoco-method-filter-sbtplugin and modernizing the GitHub Actions workflow for coverage checks. The changes streamline configuration, improve maintainability, and enable more granular coverage reporting by module. Additionally, new SBT aliases are introduced for easier coverage runs, and the workflow is optimized to only run coverage checks when Scala files change.Release Notes:
Related
Closes #166