aaelf64: link relocation entries to their notes

[sivan-shani]

Replace ambiguous “see notes below” text with named RST footnote references.

[sivan-shani]

@smithp35
@stuij

[sivan-shani]

Before:


After:

[smithp35]

I think if we are going to do this change, then it needs to be done to all the relocation tables so the document is stylistically consistent. I can see a few tables with the (see notes below) interleaved with your suggested change. Can you go through all the relocation tables?

[smithp35]

Thanks for the update. That looks good to me, although I'd like to keep this open for a while to give other reviewers the opportunity to comment/object.

[ilinpv]

Before: After:

Thanks for the readability improvements! I think these numbered backlinks 1,2,3,4 can be a bit confusing. Could we use the relocation names they refer back to instead or some other text that makes it clear what each link points back to?

[stuij]

Or remove the backlinks altogether if that's possible.

[sivan-shani]

Commit rebased on main and updated to include named commits with no backlinks.
It seems as rst does not implement named backlinkes.

Example:

[smithp35]

Thanks for the updates. Even though it loses the back-references it should remove the confusion over the numbers.

Link to the rendered doc https://github.com/sivan-shani/abi-aa/blob/f7a8f1f613d62f669e168bad23707e030af01dc8/aaelf64/aaelf64.rst

@stuij @ilinpv if Sivan's can you let us know if these changes are OK for you? Once the @ characters have been removed I can approve.

[smithp35]

I think the @ character in these 3 references isn't needed. It is showing up raw in the text. I think these are the only references with the @

[stuij]

Yea this looks fine to me.

[stuij]

The way the links look in general I mean of course.

[ilinpv]

Thanks @sivan-shani for the patch updates, named commits even without backlinks look good to me.

[sivan-shani]

Redundant '@' removed, reviewers approve,
@smithp35 Could you please merge? Thank you.