Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "apiops-cycles-method-data",
"version": "4.2.0",
"version": "4.2.1",
"description": "APIOps Cycles Method data and canvases",
"license": "Apache-2.0",
"type": "module",
Expand Down
38 changes: 38 additions & 0 deletions scripts/test-method-content-integrity.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,20 @@ for (const locale of localeDirs) {
for (const locale of Object.keys(localizedCanvasDataJson)) {
const localizedCanvases = localizedCanvasDataJson[locale] || {};

for (const canvasId of Object.keys(localizedCanvases)) {
if (!knownCanvasIds.has(canvasId)) {
findings.push(`Locale ${locale} has localization for unknown canvas "${canvasId}".`);
continue;
}

const knownSectionIds = new Set((canvasDataJson[canvasId].sections || []).map((section) => section.id));
for (const sectionId of Object.keys(localizedCanvases[canvasId].sections || {})) {
if (!knownSectionIds.has(sectionId)) {
findings.push(`Locale ${locale} has localization for unknown section "${canvasId}.${sectionId}".`);
}
}
}

for (const [canvasId, canvas] of Object.entries(canvasDataJson)) {
const localizedCanvas = localizedCanvases[canvasId];
if (!localizedCanvas) {
Expand All @@ -390,6 +404,21 @@ for (const locale of Object.keys(localizedCanvasDataJson)) {
findings.push(`Locale ${locale} is missing canvas howToUse for "${canvasId}".`);
}

if (locale !== "en") {
const englishCanvas = localizedCanvasDataJson.en?.[canvasId];
if (locale === "de" && localizedCanvas.title !== englishCanvas?.title) {
findings.push(`Locale de must keep the English canvas name for "${canvasId}.title".`);
}
for (const field of ["title", "purpose", "howToUse"]) {
if (locale === "de" && field === "title") {
continue;
}
if (localizedCanvas[field] === englishCanvas?.[field]) {
findings.push(`Locale ${locale} still uses English fallback for "${canvasId}.${field}".`);
}
}
}

for (const section of canvas.sections || []) {
const localizedSection = localizedCanvas.sections?.[section.id];
if (!localizedSection) {
Expand All @@ -403,6 +432,15 @@ for (const locale of Object.keys(localizedCanvasDataJson)) {
if (!String(localizedSection.description || "").trim()) {
findings.push(`Locale ${locale} is missing section description for "${canvasId}.${section.id}".`);
}

if (locale !== "en") {
const englishSection = localizedCanvasDataJson.en?.[canvasId]?.sections?.[section.id];
for (const field of ["section", "description"]) {
if (localizedSection[field] === englishSection?.[field]) {
findings.push(`Locale ${locale} still uses English fallback for "${canvasId}.${section.id}.${field}".`);
}
}
}
}
}
}
Expand Down
Loading
Loading