Skip to content

Update SciML src and tests to use libpetab linting#3194

Draft
BSnelling wants to merge 6 commits into
mainfrom
bes/sciml_lint
Draft

Update SciML src and tests to use libpetab linting#3194
BSnelling wants to merge 6 commits into
mainfrom
bes/sciml_lint

Conversation

@BSnelling

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.90%. Comparing base (3a1babe) to head (f9893da).

Files with missing lines Patch % Lines
python/sdist/amici/sim/jax/petab.py 88.23% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3a1babe) and HEAD (f9893da). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (3a1babe) HEAD (f9893da)
python 11 4
sbmlsuite-jax 3 0
cpp 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3194       +/-   ##
===========================================
- Coverage   75.73%   48.90%   -26.84%     
===========================================
  Files         317      317               
  Lines       20903    20871       -32     
  Branches     1484     1483        -1     
===========================================
- Hits        15830    10206     -5624     
- Misses       5061    10558     +5497     
- Partials       12      107       +95     
Flag Coverage Δ
cpp ?
cpp_python 36.75% <0.00%> (+0.04%) ⬆️
petab 40.10% <0.00%> (+0.02%) ⬆️
petab_sciml 15.42% <89.47%> (?)
python 36.90% <0.00%> (-31.42%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...hon/sdist/amici/importers/petab/_petab_importer.py 52.40% <100.00%> (+2.02%) ⬆️
python/sdist/amici/sim/jax/petab.py 76.29% <88.23%> (+17.72%) ⬆️

... and 212 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant