CI: Fix installation of benchmark_models_petab#3190
Merged
Conversation
Building the wheel for benchmark_models_petab fails with current setuptools. Symlink issues. Use editable installation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3190 +/- ##
==========================================
- Coverage 78.05% 77.40% -0.66%
==========================================
Files 317 317
Lines 20903 20903
Branches 1483 1483
==========================================
- Hits 16316 16180 -136
- Misses 4579 4715 +136
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Jun 23, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the benchmark-collection CI workflow to install Benchmark-Models-PEtab via an editable VCS install to avoid wheel build failures caused by recent setuptools behavior around symlinks.
Changes:
- Switch
pip installofBenchmark-Models-PEtabtopip install -ein the CPP and JAX benchmark jobs. - Quote the VCS URL so the
&egg=...fragment is not interpreted by the shell.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the wheel for benchmark_models_petab fails with current setuptools. Symlink issues. Use editable installation.