Skip to content

Extend support for extracting common subexpressions#3170

Draft
dweindl wants to merge 2 commits into
AMICI-dev:mainfrom
dweindl:switch_cse
Draft

Extend support for extracting common subexpressions#3170
dweindl wants to merge 2 commits into
AMICI-dev:mainfrom
dweindl:switch_cse

Conversation

@dweindl

@dweindl dweindl commented Apr 27, 2026

Copy link
Copy Markdown
Member

Extend support for extracting common subexpressions to previously unsupported functions such as sx0. Add tests.

@dweindl dweindl self-assigned this Apr 27, 2026
@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.43%. Comparing base (b832ca3) to head (86c96b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3170      +/-   ##
==========================================
- Coverage   78.05%   77.43%   -0.63%     
==========================================
  Files         317      317              
  Lines       20903    20909       +6     
  Branches     1483     1483              
==========================================
- Hits        16316    16190     -126     
- Misses       4579     4711     +132     
  Partials        8        8              
Flag Coverage Δ
cpp 71.57% <100.00%> (+<0.01%) ⬆️
cpp_python 36.71% <62.50%> (+<0.01%) ⬆️
petab 46.78% <62.50%> (+<0.01%) ⬆️
petab_sciml 15.54% <12.50%> (-0.01%) ⬇️
python 68.32% <100.00%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/sdist/amici/exporters/sundials/cxxcodeprinter.py 95.79% <100.00%> (+0.22%) ⬆️
python/sdist/amici/exporters/sundials/de_export.py 96.44% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dweindl added 2 commits June 25, 2026 09:21
Extend support for extracting common subexpressions to previously unsupported
functions such as `sx0`. Add tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support extracting common subexpressions in sx0 and sx0_fixedParameters

1 participant