Repository navigation
fix(kernelforge): reject failed allclose verdicts alongside SNR - #2333
Draft
Zhu-Jingwen wants to merge 1 commit into
Draft
Zhu-Jingwen wants to merge 1 commit into
Zhu-Jingwen wants to merge 1 commit into
Conversation
Aggregate every recognized allclose verdict and require no failed check alongside the existing SNR threshold. Preserve SNR-only, allclose-only and nonzero-exit behavior; cover contradictory metrics and both mixed-verdict orders. Co-authored-by: Huazeng Li <Huazeng.Li@amd.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zero-exit driver printing
SNR: 60.0 dBandallclose: Falsepasses a 30 dB threshold because the SNR branch ignores the failed verdict. Reading only the first allclose match also lets a later failed case or state check hide behind an earlier success.Aggregate every recognized allclose verdict and require no failed check alongside the existing SNR threshold. Preserve nonzero-exit rejection and existing SNR-only/allclose-only behavior.
Observable effect: any emitted failed allclose verdict rejects the candidate even when SNR is high. This intentionally tightens acceptance policy while keeping numerical threshold values unchanged. Emitted
allcloseremains a check verdict; optional diagnostics must use a different label.Validation:
Single concern: correctness verdict aggregation. No CLI or schema change. This validates emitted checks; it does not enforce omitted checks or protect an edited oracle. No generated-candidate GPU qualification is claimed.
Lineage: preserves Huazeng Li's author credit from the originating fix. Jingwen Zhu adapted and verified the patch against the current source layout.
Base:
d3df5b59f4712648d69cde2286dffac8040bc0d4.Full local CPU regression (
pytest -m "not targeted_build_e2e" -q -n 4): 40 failed, 26897 passed, 64 skipped, 28 warnings, 21 errors, 3 subtests passed in 603.36s (0:10:03). The 40 failed node IDs and 21 collection-error IDs exactly match unchanged main (40 failed, 26891 passed, 64 skipped, 28 warnings, 21 errors, 3 subtests passed in 607.33s (0:10:07)). This change introduces no additional failed or error node in this environment; this is not a green full-suite claim. The PR remains draft pending upstream CI and review.Verified baseline regression control: 3 failed, 3 passed, 20 deselected in 0.36s. Those fixtures were run outside the patched worktree with an assertion that the imported production module came from unchanged upstream main. The corresponding fixed cases pass in the focused selection.