Skip to content

Remove the deprecated method isValid for Collections #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmcarcell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the deprecated method isValid for Collections #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/podio/CollectionBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ class CollectionBase {

virtual bool hasID() const = 0;

virtual bool isValid() const = 0;

/// number of elements in the collection
virtual size_t size() const = 0;

Expand Down
6 changes: 0 additions & 6 deletions include/podio/UserDataCollection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,6 @@ class UserDataCollection : public CollectionBase {
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
}

[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
"collection is valid")]]
bool isValid() const override {
return hasID();
}

/// number of elements in the collection
size_t size() const override {
return _vec.size();
Expand Down
6 changes: 0 additions & 6 deletions include/podio/detail/LinkCollectionImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,6 @@ class LinkCollection : public podio::CollectionBase {
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
}

[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
"collection is valid")]]
bool isValid() const override {
return hasID();
}

podio::CollectionWriteBuffers getBuffers() override {
return m_storage.getCollectionBuffers(m_isSubsetColl);
}
Expand Down
6 changes: 0 additions & 6 deletions python/templates/Collection.h.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,6 @@ public:
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
}

[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
"collection is valid")]]
bool isValid() const final {
return hasID();
}

size_t getDatamodelRegistryIndex() const final;

// support for the iterator protocol
Expand Down
Loading