Support nested outputs correctness check and use Xprof time instead of wall time by default#62
Merged
Merged
Conversation
shangkunwang01
commented
Jul 6, 2026
shangkunwang01
commented
Collaborator
- The evaluation cannot work if the there are multiple outputs from the test function. This pr fix this by comparing all the outputs
- Use Xprof XLA Module time as the default time for calculating speedups
- Poison HBM memory to prevent kernels from inheriting residuals
…d add XProf speedup calculation support
NinaCai
reviewed
Jul 7, 2026
| dummy.block_until_ready() | ||
| del dummy | ||
| except Exception: | ||
| pass |
Collaborator
There was a problem hiding this comment.
This is a silent failure, could you explicitly show a log that it fails to dirty the HBM memory?
Collaborator
Author
There was a problem hiding this comment.
Added logging to the harness and pass it to result.
| else: | ||
| val = 123 # Fits within int8/uint8 and all larger integer dtypes | ||
|
|
||
| dummy = jax.device_put(jnp.full(leaf.shape, val, dtype=leaf.dtype)) |
Collaborator
There was a problem hiding this comment.
device_put() is redundant, it should be removed.
Should be
dummy = jnp.full(leaf.shape, val, dtype=leaf.dtype)
Collaborator
Author
There was a problem hiding this comment.
Thanks, removed.
NinaCai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.