Skip to content

Configurable workspace selection and compilation retries#60

Merged
LukeA12 merged 5 commits into
mainfrom
luke-maxkernel-updates-after-testing
Jul 8, 2026
Merged

Configurable workspace selection and compilation retries#60
LukeA12 merged 5 commits into
mainfrom
luke-maxkernel-updates-after-testing

Conversation

@LukeA12

@LukeA12 LukeA12 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This PR adds two new features to MaxKernel:

  1. It allows the user to ask MaxKernel to set a working directory. Previously MaxKernel defaulted to only working out of the accelerator-agents/MaxKernel directory, which limited it's ability to read and write to kernel files located in other directories. In my testing, this was an inconvenience because I would have to manually copy the optimized kernel over to the directory I wanted to work from when MaxKernel was finished. Now the user can simply ask MaxKernel to work in a specified directory and it will do so; no manual copying needed. I verified this worked in the MaxKernel UI:
image image
  1. It also allows the user to configure the max number of retries MaxKernel works through a compilation error. Currently this is set to 4 for the hitl_agent and 6 for the auto_agent. In my testing, I found that four iterations was fine when asking it to make incremental commits with clear direction, but it was too restrictive when giving it a larger goal of fully optimizing a kernel in which significant code changes might be required. When I asked it to do this, it almost always hit the 4 iteration limit which blocked further progress. For this reason, I have incremented the default iteration limit for the hitl_agent to be 6 (matching the auto_agent) and also added the ability for the user to request this limit be changed if needed. I verified this worked by testing in the MaxKernel UI:
image

@LukeA12 LukeA12 requested review from NinaCai and shangkunwang01 July 6, 2026 18:42
Comment thread MaxKernel/hitl_agent/tools/retries_tool.py Outdated
Comment thread MaxKernel/hitl_agent/tools/workspace_tool.py
@LukeA12 LukeA12 requested a review from shangkunwang01 July 7, 2026 21:53
Comment thread MaxKernel/hitl_agent/tools/retries_tool.py Outdated
Comment thread MaxKernel/hitl_agent/tools/workspace_tool.py Outdated

@NinaCai NinaCai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Luke for this PR! I left a few comments.

@LukeA12 LukeA12 requested a review from NinaCai July 8, 2026 17:57
@LukeA12 LukeA12 merged commit 8830839 into main Jul 8, 2026
7 checks passed
@LukeA12 LukeA12 deleted the luke-maxkernel-updates-after-testing branch July 8, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants