Skip to content

THREESCALE-12076: Upgrade Rails to 7.2 #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayorova wants to merge 14 commits into
base: strong-params-part3
Choose a base branch
from
Open

THREESCALE-12076: Upgrade Rails to 7.2 #4232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6b3858f
Upgrade rails to 7.2 and dependencies
mayorova Feb 24, 2026
533284b
Upgrade other dependencies
mayorova Feb 24, 2026
e24591a
rails app:update
mayorova Feb 24, 2026
35d0c34
Set the default threads count for Puma to 3
mayorova Mar 24, 2026
4bf8395
Fix some deprecations and warnings
mayorova Feb 26, 2026
326d9e2
Fix formatting issues
mayorova Feb 26, 2026
f7b0e46
Fix: private method 'warn' called for class ActiveSupport::Deprecation
mayorova Mar 25, 2026
986ae90
Use ActiveJob::QueueAdapters::TestAdapter for tests
mayorova Mar 26, 2026
8feb3a5
Replace assert_nothing_raised with another assertion
mayorova Apr 30, 2026
1283acb
Fix Oracle hack for visit_Arel_Nodes_In
mayorova May 26, 2026
778294a
Add gems that will not be in Ruby 3.4 to remove deprecation warnings
mayorova Jun 3, 2026
495e38d
Apply config defaults version 7.2
mayorova Jun 3, 2026
ccf1dad
Bump version to 7.2 in DB schema
mayorova Jun 3, 2026
1b1fd1d
Fix disabling auditing in tests after audited upgrade
mayorova Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ gem 'aws-sdk-rails', '~> 3'
gem 'aws-sdk-s3', '~> 1'

gem 'dotenv-rails', '~> 2.7'
gem 'rails', '~> 7.1.5'
gem 'rails', '~> 7.2.3'

gem 'mail', '~> 2.8.1'

Expand Down Expand Up @@ -59,7 +59,7 @@ gem 'yabeda-prometheus-mmap'
gem 'yabeda-sidekiq'

gem 'activemerchant', '~> 1.137'
gem 'audited', '~> 5.4.2'
gem 'audited', '~> 5.8.0'

@mayorova mayorova Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for Rails 7.2 was added in 5.7.0 https://github.com/collectiveidea/audited/blob/main/CHANGELOG.md#570-2024-08-13

gem 'stripe', '~> 5.28.0' # we need the stripe gem because activemerchant can not generate Stripe's "customers"

gem 'acts_as_list', '~> 0.9.17'
Expand All @@ -85,7 +85,7 @@ gem 'secure_headers', '~> 6.3.0'
gem 'redlock'

gem 'acts-as-taggable-on', '~> 11.0'
gem 'baby_squeel', '~> 3.0', '>= 3.0.0'
gem 'baby_squeel', '~> 4.0.0'

@jlledom jlledom Mar 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes here?

@mayorova mayorova Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It drops support for some Ruby and Rails versions, but it doesn not affect us here:
https://github.com/rzane/baby_squeel/blob/master/CHANGELOG.md#400---2024-11-29

  • Remove ActiveRecord boundary
  • Added support for ActiveRecord 8.1
  • Added support for Ransack 4.4 ([webpack] Do not precompile webpack assets #134)
  • Added support for ActiveRecord 8.0
  • Added support for ActiveRecord 7.2
  • Droped support for ActiveRecord 6.1 and 7.0
  • Added Ruby 3.3 and 3.4 to test matrix
  • Droped support for Ruby 3.0 and 3.1

@akostadinov akostadinov Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no announced breaking changes, we can fully trust that!

gem 'browser'
gem 'diff-lcs', '~> 1.2'
gem 'hiredis-client'
Expand Down Expand Up @@ -222,7 +222,7 @@ group :development, :test do
gem 'active_record_query_trace'

gem 'bootsnap', '~> 1.16'
gem 'bullet', '~> 7.1.6'
gem 'bullet', '~> 7.2.0'
gem 'colorize'
gem 'factory_bot_rails', '~> 6.2'

Expand All @@ -248,10 +248,13 @@ group :oracle do
oracle = -> { (ENV['ORACLE'] == '1') || ENV.fetch('DATABASE_URL', ENV['DB'])&.start_with?('oracle') }
# ENV['NLS_LANG'] ||= 'AMERICAN_AMERICA.AL32UTF8' if oracle
ENV['NLS_LANG'] ||= 'AMERICAN_AMERICA.UTF8' if oracle
gem 'activerecord-oracle_enhanced-adapter', '~> 7.1.0', install_if: oracle
gem 'activerecord-oracle_enhanced-adapter', '~> 7.2.0', install_if: oracle
gem 'ruby-oci8', require: false, install_if: oracle
end

gem 'kubeclient'
gem 'nkf'
gem 'pg', '~> 1.3.5'
gem 'mutex_m'

@mayorova mayorova Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to get rid of the following warnings:

/home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/gems/3.3.0/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32: warning: /home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/3.3.0/mutex_m.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec.

/home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/gems/3.3.0/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32: warning: /home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/3.3.0/observer.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add observer to your Gemfile or gemspec. Also contact author of factory_bot-6.2.0 to add observer into its gemspec.

/home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/gems/3.3.0/gems/bootsnap-1.16.0/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:32: warning: /home/dmayorov/.asdf/installs/ruby/3.3.1/lib/ruby/3.3.0/csv.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec.

gem 'observer'
gem 'csv'
Loading