Skip to content

test: golden end-to-end .star scripts + downstream-compat docs#72

Merged
vt128 merged 1 commit into
masterfrom
golden-star-tests
Jun 12, 2026
Merged

test: golden end-to-end .star scripts + downstream-compat docs#72
vt128 merged 1 commit into
masterfrom
golden-star-tests

Conversation

@vt128

@vt128 vt128 commented Jun 12, 2026

Copy link
Copy Markdown
Member

What

  • testdata/golden/{conversion,dialect}.star — classic scripts run through the real interpreter (starlight_features_test.go section 3, per the test-organization rule: a section, not new files). They exercise the headline conversion behaviors end-to-end: deterministic map order (keys == sorted == iteration), empty-interface unwrapping (JSON-shaped values native & usable), tuple + big-int map keys round-tripping, str() safety, and the compiled dialect (set/lambda/float/bitwise/nested-def). Scripts self-describe via out_* globals; the Go runner asserts a checks map. Cheapest layer to extend when a fix has script-observable behavior.
  • CLAUDE.md — documents the two-leg downstream compatibility matrix as a release gate (baseline vs upgrade leg, Docker go1.19, regression = upgrade-leg-only, known pre-existing failures, MVS L0 bump), and the golden-test convention.

Tests

TestGoldenConversion + TestGoldenDialect run the scripts and assert outputs. Full suite -race; Go 1.19 via Docker.

🤖 Generated with Claude Code

… gate

- testdata/golden/{conversion,dialect}.star: classic scripts run through
  the real interpreter (starlight_features_test.go section 3) covering
  deterministic map order, empty-interface unwrapping, tuple/big-int
  keys, str() safety, and the compiled dialect. Cheapest end-to-end
  regression layer; assert via out_* globals.
- CLAUDE.md: document the two-leg downstream compatibility matrix as a
  release gate (baseline vs upgrade leg, Docker go1.19, known
  pre-existing failures), and the golden-test convention.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Jun 12, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 10 complexity · 0 duplication

Metric Results
Complexity 10
Duplication 0

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e1dc40) 2124 1915 90.16%
Head commit (d2f3ca7) 2124 (+0) 1915 (+0) 90.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#72) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.12%. Comparing base (2e1dc40) to head (d2f3ca7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files           8        8           
  Lines        1662     1662           
=======================================
  Hits         1448     1448           
  Misses        131      131           
  Partials       83       83           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vt128 vt128 merged commit 300e254 into master Jun 12, 2026
14 checks passed
@vt128 vt128 deleted the golden-star-tests branch June 12, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant