F-4830 Integer Overflow#246
Open
aidankeefe2022 wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #246
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the base64 decode output-size calculation in wolfCLU_Base64Setup to avoid potential integer overflow by replacing (inputSz * 3) / 4 with an overflow-safer equivalent expression.
Changes:
- Replaced the base64 decode output buffer size formula with an equivalent computation that avoids
inputSz * 3overflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* For regular base64 decoding */ | ||
| /* Calculate output size */ | ||
| outputSz = (inputSz * 3) / 4 + 1; | ||
| outputSz = (inputSz / 4) * 3 + (inputSz % 4) * 3 / 4 + 1; |
aidankeefe2022
force-pushed
the
F-4830-Integer-Overflow
branch
from
9eec52f to
711d0e3
Compare
aidankeefe2022
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed math operation to be slower but removed chance of integer overflow