ML-DSA sign verify command#245
Open
stenslae wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #245
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an ml-dsa alias for the existing Dilithium sign/verify path in wolfCLU, and also extends the rand command implementation and regression test coverage (not mentioned in the PR description).
Changes:
- Add
ml-dsaas an alias fordilithiumacross mode selection, sign/verify setup, and help output. - Refactor
randargument parsing to robustly recover the positional byte-count, reject duplicate/unknown flags, defer-outfile creation until after validation, and generate large outputs in chunks. - Expand Python test coverage for
randparsing edge cases and forml-dsaalias behavior in gen/sign/verify flows.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rand/rand-test.py | Adds extensive regression coverage for rand parsing, duplicate flags, size overflow guards, and large-output behavior. |
| tests/genkey_sign_ver/genkey-sign-ver-test.py | Adds tests validating ml-dsa as an alias and cross-compatibility with dilithium. |
| src/tools/clu_rand.c | Implements stricter positional parsing/validation, duplicate detection, deferred -out opening, and chunked RNG generation. |
| src/tools/clu_funcs.c | Updates help output to advertise ml-dsa and dilithium aliasing; adds ML-DSA help text. |
| src/sign-verify/clu_sign_verify_setup.c | Recognizes ml-dsa as selecting the Dilithium sign/verify path; updates a user-facing error string. |
| src/clu_main.c | Registers ml-dsa as a top-level mode mapped to the Dilithium handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8f20555 to
790e07f
Compare
790e07f to
7b2ae8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE 189 FIX: Added an alias so both ml-dsa and dilithium subcommands can be used.