Skip to content

ML-DSA sign verify command#245

Open
stenslae wants to merge 1 commit into
wolfSSL:mainfrom
stenslae:ml-dsa-sign-verify
Open

ML-DSA sign verify command#245
stenslae wants to merge 1 commit into
wolfSSL:mainfrom
stenslae:ml-dsa-sign-verify

Conversation

@stenslae

@stenslae stenslae commented Jun 3, 2026

Copy link
Copy Markdown
Member

ISSUE 189 FIX: Added an alias so both ml-dsa and dilithium subcommands can be used.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #245

Scan targets checked: wolfclu-bugs, wolfclu-src

No new issues found in the changed files. ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an ml-dsa alias for the existing Dilithium sign/verify path in wolfCLU, and also extends the rand command implementation and regression test coverage (not mentioned in the PR description).

Changes:

  • Add ml-dsa as an alias for dilithium across mode selection, sign/verify setup, and help output.
  • Refactor rand argument parsing to robustly recover the positional byte-count, reject duplicate/unknown flags, defer -out file creation until after validation, and generate large outputs in chunks.
  • Expand Python test coverage for rand parsing edge cases and for ml-dsa alias behavior in gen/sign/verify flows.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/rand/rand-test.py Adds extensive regression coverage for rand parsing, duplicate flags, size overflow guards, and large-output behavior.
tests/genkey_sign_ver/genkey-sign-ver-test.py Adds tests validating ml-dsa as an alias and cross-compatibility with dilithium.
src/tools/clu_rand.c Implements stricter positional parsing/validation, duplicate detection, deferred -out opening, and chunked RNG generation.
src/tools/clu_funcs.c Updates help output to advertise ml-dsa and dilithium aliasing; adds ML-DSA help text.
src/sign-verify/clu_sign_verify_setup.c Recognizes ml-dsa as selecting the Dilithium sign/verify path; updates a user-facing error string.
src/clu_main.c Registers ml-dsa as a top-level mode mapped to the Dilithium handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/rand/rand-test.py
Comment thread src/tools/clu_funcs.c Outdated
Comment thread src/tools/clu_rand.c Outdated
@cconlon cconlon assigned stenslae and unassigned cconlon Jun 8, 2026
@stenslae stenslae force-pushed the ml-dsa-sign-verify branch from 8f20555 to 790e07f Compare June 8, 2026 20:38
@stenslae stenslae force-pushed the ml-dsa-sign-verify branch from 790e07f to 7b2ae8a Compare June 8, 2026 20:54
@stenslae stenslae assigned cconlon and unassigned stenslae Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants