Fix sanitizer flags for vortex-ffi doctests in CI#8315
Draft
joseph-isaacs wants to merge 2 commits into
Draft
Conversation
The vortex-ffi sanitizer test step runs doctests via rustdoc, which reads RUSTDOCFLAGS rather than RUSTFLAGS. Without the sanitizer flag the doctest harness was built with an unset -Zsanitizer while its dependencies were built with -Zsanitizer=thread, causing rustc to reject the ABI mismatch. Mirror the sanitizer flags into RUSTDOCFLAGS so the doctest harness matches its dependencies. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
216.9 ns | 275.3 ns | -21.19% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
278.6 ns | 336.9 ns | -17.31% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
191.4 µs | 227.8 µs | -16% |
| ❌ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
205.7 µs | 242 µs | -15.01% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
342.2 ns | 400.6 ns | -14.56% |
| ❌ | Simulation | take_map[(0.1, 0.5)] |
993.6 µs | 1,125.5 µs | -11.72% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
46.9 µs | 32 µs | +46.91% |
| ⚡ | Simulation | compare[6] |
79.5 µs | 70 µs | +13.46% |
| ⚡ | Simulation | compare[6] |
79.2 µs | 70 µs | +13.24% |
| ⚡ | Simulation | compare[6] |
80.8 µs | 71.5 µs | +13.1% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
311.3 µs | 276.2 µs | +12.72% |
| ⚡ | Simulation | encode_varbin[(1000, 4)] |
161.5 µs | 144.1 µs | +12.01% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
168.3 µs | 150.4 µs | +11.92% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
162.2 µs | 145.2 µs | +11.74% |
| ⚡ | Simulation | compare[5] |
75.4 µs | 67.9 µs | +11.09% |
| ⚡ | Simulation | compare[5] |
76 µs | 68.5 µs | +10.93% |
| ⚡ | Simulation | compare[5] |
77.1 µs | 69.6 µs | +10.77% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
363.2 µs | 328.2 µs | +10.66% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/fervent-hopper-7hi48e (0c4b3e4) with develop (d650cab)
myrrc
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
vortex-ffitests with sanitizers enabled in CI, doctests were failing due to an ABI mismatch. Doctests are compiled byrustdoc, which readsRUSTDOCFLAGSrather thanRUSTFLAGS. Without the sanitizer flags inRUSTDOCFLAGS, the doctest harness was built with different compiler settings than its dependencies, causingrustcto reject the ABI mismatch.This change mirrors the sanitizer flags to
RUSTDOCFLAGSso the doctest harness is built with the same-Zsanitizervalue as its dependencies.Testing
The fix will be validated by the existing
rust-instrumentedCI workflow, which runs thevortex-ffitests with sanitizers enabled. The doctests should now compile and run successfully without ABI mismatch errors.https://claude.ai/code/session_01F3PLB1BLD38qjmBezhSZQd