-
Notifications
You must be signed in to change notification settings - Fork 180
Expand file tree
/
Copy pathclippy.toml
More file actions
21 lines (20 loc) · 1.8 KB
/
Copy pathclippy.toml
File metadata and controls
21 lines (20 loc) · 1.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
allow-dbg-in-tests = true
allow-expect-in-tests = true
allow-unwrap-in-tests = true
allow-panic-in-tests = true
absolute-paths-max-segments = 3
single-char-binding-names-threshold = 2
disallowed-types = [
{ path = "std::collections::HashMap", reason = "Use the HashMap in vortex_utils::aliases for better performance" },
{ path = "std::collections::HashSet", reason = "Use the HashSet in vortex_utils::aliases for better performance" },
{ path = "std::sync::Mutex", reason = "Prefer using parking_lot Mutex for improved ergonomics and performance" },
{ path = "std::sync::RwLock", reason = "Prefer using parking_lot RwLock for improved ergonomics and performance" },
]
disallowed-methods = [
{ path = "itertools::Itertools::counts", reason = "It uses the default hasher which is slow for primitives. Just inline the loop for better performance.", allow-invalid = true },
{ path = "std::result::Result::and", reason = "This method is a footgun, especially when working with `Result<Validity>`." },
{ path = "std::thread::available_parallelism", reason = "This function might do an unbounded amount of work, use `vortex_utils::parallelism::get_available_parallelism instead" },
{ path = "vortex_session::registry::Id::new", reason = "Interning a static id on every call grabs the interner lock (#8380). Use a `CachedId` static for static ids; for a dynamic string, annotate the call with `#[expect(clippy::disallowed_methods)]`.", allow-invalid = true },
{ path = "vortex_session::registry::Id::new_static", reason = "Interning a static id on every call grabs the interner lock; use a `CachedId` static instead (#8380).", allow-invalid = true },
{ path = "vortex_array::legacy_session", reason = "Relies on the hidden global session; thread an explicit `VortexSession`/`ExecutionCtx` through instead" },
]