fix: stop installation when MSI enumeration fails

Keep the Windows integration fixture on the user volume so plugin staging can finish before installer validation.

Fixes version-fox/vfox#685

Author: aooohan

.github/workflows/hooks-test.yml

@@ -53,7 +53,8 @@ jobs:
           $ErrorActionPreference = 'Stop'
           $PSNativeCommandUseErrorActionPreference = $true
           # Literal percent/exclamation marks also catch cmd expansion bugs.
-          $env:VFOX_HOME = Join-Path $env:RUNNER_TEMP 'Mechael Jackson''s & %USERNAME% ! SDKs'
+          # Keep plugin staging and installation on the user's volume.
+          $env:VFOX_HOME = Join-Path $env:USERPROFILE 'Mechael Jackson''s & %USERNAME% ! SDKs'
           $env:VFOX_PYTHON_USE_UV_BUILD = '0'
           $archive = Join-Path $env:RUNNER_TEMP 'python-plugin.zip'
           Compress-Archive -Path metadata.lua,hooks,lib,bin -DestinationPath $archive

lib/util.lua

@@ -155,18 +155,34 @@ function windowsInstallExe(path, url, version, filename)
     if not listing then
         error('Failed to list installer packages: ' .. tostring(listErr))
     end
-    local files = listing:lines()
-    for file in files do
-        if file:match("%.msi$") then
-            local command = windowsCommand.msi(msiPath .. '\\' .. file, qInstallPath)
-            local exitCode = os.execute(command)
-            if exitCode ~= 0 then
-                error("Install msi failed: " .. file)
+    local files = {}
+    local readOk, readErr = pcall(function()
+        for file in listing:lines() do
+            if file:match("%.msi$") then
+                files[#files + 1] = file
             end
-            os.remove(qInstallPath .. '\\' .. file)
         end
+    end)
+    -- GopherLua returns the process's numeric exit status from pipe close.
+    -- Close even after a read error, and reject partial results before installing.
+    local closeOk, listExitCode = pcall(function() return listing:close() end)
+    if not readOk then
+        error('Failed to list installer packages: ' .. tostring(readErr))
+    end
+    if not closeOk or listExitCode ~= 0 then
+        error('Failed to list installer packages: ' .. tostring(listExitCode))
+    end
+    if #files == 0 then
+        error('No installer MSI packages found in: ' .. msiPath)
+    end
+    for _, file in ipairs(files) do
+        local command = windowsCommand.msi(msiPath .. '\\' .. file, qInstallPath)
+        local exitCode = os.execute(command)
+        if exitCode ~= 0 then
+            error("Install msi failed: " .. file)
+        end
+        os.remove(qInstallPath .. '\\' .. file)
     end
-    listing:close()
 
     -- Install pip
     print("Installing pip...")

tests/windows_install_test.lua

@@ -1,7 +1,12 @@
 package.path = './lib/?.lua;' .. package.path
 RUNTIME = {osType = 'windows', archType = 'amd64', pluginDirPath = "C:\\Plugin's & %USERNAME% ! store"}
 OS_TYPE = 'windows'
-local state = {commands = {}}
+local state = {commands = {}, closeCount = 0}
+local function reset()
+    for key in pairs(state) do state[key] = nil end
+    state.commands = {}
+    state.closeCount = 0
+end
 package.preload.http = function() return {download_file = function() return nil end} end
 package.preload.html = function() return {} end
 package.preload.json = function() return {} end
@@ -14,13 +19,22 @@ os.execute = function(command)
     return #state.commands == state.failOn and 1 or 0
 end
 io.popen = function(command)
-    os.execute(command)
+    local exitCode = os.execute(command)
     return {
         lines = function()
-            local files, i = {'core.msi', 'stdlib.msi'}, 0
-            return function() i = i + 1; return files[i] end
+            local files, i = state.files or {'core.msi', 'stdlib.msi'}, 0
+            return function()
+                i = i + 1
+                if state.readFailure and i == 2 then error('read failed') end
+                return files[i]
+            end
+        end,
+        close = function()
+            state.closeCount = state.closeCount + 1
+            if state.closeFailure then error('close failed') end
+            -- GopherLua process pipes return a numeric exit status, including 0.
+            return state.listExitCode or exitCode
         end,
-        close = function() return true end,
     }
 end
 io.open = function()
@@ -32,17 +46,33 @@ require('util')
 local path = "C:\\Users\\Mechael Jackson's & %USERNAME% !\\python-3.14.5"
 windowsInstallExe(path, 'https://example.invalid/python.exe', '3.14.5', 'python.exe')
 assert(#state.commands >= 7, 'installer, enumeration, MSI, pip and aliases must be exercised')
-state.commands = {}
+reset()
 windowsInstallMsi(path, 'https://example.invalid/python.msi', '3.4.4', 'python.msi')
 assert(#state.commands == 2, 'MSI and ensurepip must both run')
 for _, failure in ipairs({{1, 'Extract failed'}, {3, 'Install msi failed'}, {6, 'executable alias'}}) do
-    state.commands = {}
+    reset()
     state.failOn = failure[1]
     local ok, err = pcall(function()
         windowsInstallExe(path, 'https://example.invalid/python.exe', '3.14.5', 'python.exe')
     end)
     assert(not ok and tostring(err):find(failure[2], 1, true), tostring(err))
 end
+for _, failure in ipairs({
+    {name = 'partial listing exits nonzero', files = {'core.msi'}, exitCode = 1, message = 'Failed to list installer packages'},
+    {name = 'listing read failure', readFailure = true, message = 'read failed'},
+    {name = 'listing close failure', closeFailure = true, message = 'close failed'},
+    {name = 'no MSI packages', files = {'readme.txt'}, message = 'No installer MSI packages'},
+}) do
+    reset()
+    state.files = failure.files
+    state.listExitCode = failure.exitCode
+    state.readFailure = failure.readFailure
+    state.closeFailure = failure.closeFailure
+    local ok, err = pcall(windowsInstallExe, path, 'https://example.invalid/python.exe', '3.14.5', 'python.exe')
+    assert(not ok and tostring(err):find(failure.message, 1, true), failure.name .. ': ' .. tostring(err))
+    assert(state.closeCount == 1, failure.name .. ': listing handle must be closed')
+    assert(#state.commands == 2, failure.name .. ': no MSI or pip may run before enumeration succeeds')
+end
 local windows = require('windows_command')
 assert(not pcall(windows.msi, 'C:\\bad"path\\python.msi', path), 'invalid Windows quote must fail')
 assert(not pcall(windows.native, 'bad\nprogram', {}), 'control characters must fail')