feat: Support OIDC login using solid-oidc-client (with threading.Thread)#43
Open
renyuneyun wants to merge 2 commits into
Open
feat: Support OIDC login using solid-oidc-client (with threading.Thread)#43renyuneyun wants to merge 2 commits into
threading.Thread)#43renyuneyun wants to merge 2 commits into
Conversation
The library solid-oidc-client currently has caveats for token refresh (etc). Use with caution.
multiprocessing.Process requires pickling its arguments, which fails on Python 3.14 (forkserver default) because SolidOidcClient contains an unpicklable RLock. A daemon Thread shares memory directly and needs no serialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #38 , but uses
threading.Threadinstead ofmultiprocessing.Process.In fact, this one creates another commit on top of the HEAD in #38 , just for this switching.
The reason for this switch is due to Python 3.14 underlying changes, so
RLockwithProcesswon't work anymore on *nix.