chore: Use StructArmed on QA

Author: samsonasik

.gitattributes

@@ -19,6 +19,7 @@ phpunit.xml               export-ignore
 phpunit.xml.dist          export-ignore
 README.md                 export-ignore
 rector.php                export-ignore
+structarmed.php           export-ignore
 cliff.toml                export-ignore
 .commitlintrc.json        export-ignore
 

.github/workflows/coding-conventions.yml

@@ -65,7 +65,7 @@ jobs:
             phpstan-result-cache-
 
       - name: Run PHPStan
-        run: vendor/bin/phpstan --error-format=github -vv 
+        run: vendor/bin/phpstan --error-format=github -vv
 
       - name: Save PHPStan result cache
         uses: actions/cache/save@v4
@@ -92,3 +92,22 @@ jobs:
 #
 #      - name: Run Rector
 #        run: vendor/bin/rector process --no-ansi --dry-run --no-progress-bar
+
+
+  structarmed:
+    name: "Run static analysis: StructArmed"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.5
+          coverage: none
+
+      - name: Install composer dependencies
+        uses: ramsey/composer-install@v3
+
+      - name: Run StructArmed
+        run: vendor/bin/structarmed analyze

composer.json

@@ -92,7 +92,8 @@
         "thenetworg/oauth2-azure": "^2.2",
         "twig/twig": "^3.16",
         "vertisan/oauth2-twitch-helix": "^2.0",
-        "wohali/oauth2-discord-new": "^1.2"
+        "wohali/oauth2-discord-new": "^1.2",
+        "boundwize/structarmed": "^0.17.9"
     },
     "replace": {
         "tempest/auth": "self.version",

packages/auth/src/AccessControl/PolicyBasedAccessControl.php

@@ -86,7 +86,7 @@ private function findPoliciesForResourceAction(object|string $resource, UnitEnum
         $actionBeingEvaluated = Str\parse($action);
 
         return new ImmutableArray($this->authConfig->policies[$resource] ?? [])
-            ->filter(fn ($_, string $action) => $action === $actionBeingEvaluated)
+            ->filter(static fn ($_, string $action) => $action === $actionBeingEvaluated)
             ->flatten();
     }
 
@@ -97,13 +97,13 @@ private function evaluatePolicy(MethodReflector $policy, ?object $resource, ?obj
         $this->ensureParameterAcceptsInput(
             reflector: $policy->getParameter(key: 0),
             input: $resource,
-            throw: fn (string $expected) => throw PolicyMethodWasInvalid::resourceParameterIsInvalid($policyName, $expected),
+            throw: static fn (string $expected) => throw PolicyMethodWasInvalid::resourceParameterIsInvalid($policyName, $expected),
         );
 
         $this->ensureParameterAcceptsInput(
             reflector: $policy->getParameter(key: 1),
             input: $subject,
-            throw: fn (string $expected) => throw PolicyMethodWasInvalid::subjectParameterIsInvalid($policyName, $expected),
+            throw: static fn (string $expected) => throw PolicyMethodWasInvalid::subjectParameterIsInvalid($policyName, $expected),
         );
 
         $decision = $policy->invokeArgs(

packages/auth/src/OAuth/Testing/TestingOAuthClient.php

@@ -245,7 +245,7 @@ public function assertAuthorizationUrlGenerated(?array $scopes = null, ?array $o
     public function assertUserFetched(string $code): void
     {
         Assert::assertNotEmpty(
-            actual: array_filter($this->users, fn (array $user) => $user['code'] === $code),
+            actual: array_filter($this->users, static fn (array $user) => $user['code'] === $code),
             message: sprintf('User with code "%s" was not handled.', $code),
         );
     }
@@ -259,7 +259,7 @@ public function assertAccessTokenRetrieved(?string $code = null): void
 
         if ($code !== null) {
             Assert::assertNotEmpty(
-                actual: array_filter($this->accessTokens, fn (array $token) => $token['code'] === $code),
+                actual: array_filter($this->accessTokens, static fn (array $token) => $token['code'] === $code),
                 message: sprintf('No access token was retrieved for code "%s".', $code),
             );
         }
@@ -275,7 +275,7 @@ public function assertAccessTokenRefreshed(?string $refreshToken = null): void
         if ($refreshToken !== null) {
             // @mago-expect lint:no-insecure-comparison
             Assert::assertNotEmpty(
-                actual: array_filter($this->refreshedTokens, fn (array $token) => $token['refresh_token'] === $refreshToken),
+                actual: array_filter($this->refreshedTokens, static fn (array $token) => $token['refresh_token'] === $refreshToken),
                 message: sprintf('No access token was refreshed for refresh token "%s".', $refreshToken),
             );
         }

packages/cache/src/Commands/CacheClearCommand.php

@@ -93,8 +93,8 @@ private function clearUserCaches(?string $tag = null, bool $all = false): void
             /** @var GenericContainer $container */
             $container = $this->container;
             $cacheTags = arr($container->getSingletons(CacheConfig::class))
-                ->map(fn ($_, string $key) => $key === CacheConfig::class ? self::DEFAULT_CACHE : Str\after_last($key, '#'))
-                ->filter(fn (string $value) => $tag === null || $value === $tag)
+                ->map(static fn ($_, string $key) => $key === CacheConfig::class ? self::DEFAULT_CACHE : Str\after_last($key, '#'))
+                ->filter(static fn (string $value) => $tag === null || $value === $tag)
                 ->values();
 
             if ($all === false && count($cacheTags) > 1) {

packages/cache/src/GenericCache.php

@@ -134,7 +134,7 @@ public function getMany(iterable $key): array
         if (! $this->enabled) {
             return Arr\map_with_keys(
                 array: $key,
-                map: fn (string|Stringable $key) => yield (string) $key => null,
+                map: static fn (string|Stringable $key) => yield (string) $key => null,
             );
         }
 

packages/command-bus/src/AsyncCommandRepositories/FileCommandRepository.php

@@ -52,7 +52,7 @@ public function markAsFailed(string $uuid): void
     public function getPendingCommands(): array
     {
         return arr(glob(__DIR__ . '/../stored-commands/*.pending.txt'))
-            ->mapWithKeys(function (string $path) {
+            ->mapWithKeys(static function (string $path) {
                 if (! Filesystem\is_file($path)) {
                     return;
                 }

packages/command-bus/src/MonitorAsyncCommands.php

@@ -71,7 +71,7 @@ public function __invoke(): void
                 }
 
                 $availableCommands = arr($this->repository->getPendingCommands())
-                    ->filter(fn (object $_, string $uuid) => ! array_key_exists($uuid, $processes));
+                    ->filter(static fn (object $_, string $uuid) => ! array_key_exists($uuid, $processes));
 
                 if (count($processes) === 5) {
                     $this->sleep(0.5);

packages/console/src/Actions/RenderConsoleCommand.php

@@ -75,7 +75,7 @@ private function renderArgument(ConsoleArgumentDefinition $argument): string
     private function renderEnumArgument(ConsoleArgumentDefinition $argument): string
     {
         $parts = array_map(
-            callback: fn (BackedEnum $case) => $case->value,
+            callback: static fn (BackedEnum $case) => $case->value,
             array: $argument->type::cases(),
         );