Skip to content

Commit 1b31443

Browse files
committed
Use wrapper keys for reverse filtered matchups.
Make reverse matchup expansion rely on graph wrapper type checks instead of direct item class checks so the checkbox consistently adds reverse pairs. Made-with: Cursor
1 parent ee84860 commit 1b31443

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

‎graphs/gui/canvasPanel.py‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,20 @@
3131

3232

3333
from graphs.mpl_fonts import configure_matplotlib_font
34-
from eos.saveddata.fit import Fit
35-
from eos.saveddata.targetProfile import TargetProfile
3634
from graphs.style import BASE_COLORS, LIGHTNESSES, STYLES, hsl_to_hsv
3735
from gui.utils.numberFormatter import roundToPrec
3836

3937

4038
pyfalog = Logger(__name__)
4139

4240

43-
def _graph_item_key(item):
44-
if isinstance(item, Fit):
45-
return ('fit', item.ID)
46-
if isinstance(item, TargetProfile):
47-
return ('profile', item.ID)
41+
def _graph_wrapper_key(wrapper):
42+
if wrapper is None or wrapper.item is None:
43+
return None
44+
if wrapper.isFit:
45+
return 'fit', wrapper.item.ID
46+
if wrapper.isProfile:
47+
return 'profile', wrapper.item.ID
4848
return None
4949

5050

@@ -57,20 +57,20 @@ def expand_reverse_filtered_matchups(ctrl, base_pairs):
5757
return base_pairs
5858
src_by_key = {}
5959
for w in ctrl.sources:
60-
k = _graph_item_key(w.item)
60+
k = _graph_wrapper_key(w)
6161
if k:
6262
src_by_key[k] = w
6363
tgt_by_key = {}
6464
for w in ctrl.targets:
65-
k = _graph_item_key(w.item)
65+
k = _graph_wrapper_key(w)
6666
if k:
6767
tgt_by_key[k] = w
6868
seen = set((id(s), id(t)) for s, t in base_pairs)
6969
out = list(base_pairs)
7070
for s, t in base_pairs:
7171
# Reverse matchup means target ship becomes attacker and vice versa.
72-
reverse_src_key = _graph_item_key(t.item)
73-
reverse_tgt_key = _graph_item_key(s.item)
72+
reverse_src_key = _graph_wrapper_key(t)
73+
reverse_tgt_key = _graph_wrapper_key(s)
7474
if reverse_src_key is None or reverse_tgt_key is None:
7575
continue
7676
rev_s = src_by_key.get(reverse_src_key)

0 commit comments

Comments
 (0)