function discovered in ./protocols/kad/src/behaviour.rs will always replace existing multiaddr with new ones instead of appending, is this a bug?

[clovas]

As the title says, here is the code: (line 1235)

rust-libp2p/protocols/kad/src/behaviour.rs

Lines 1219 to 1239 in de9cebb

	fn discovered<'a, I>(&'a mut self, query_id: &QueryId, source: &PeerId, peers: I)
	where
	I: Iterator<Item = &'a KadPeer> + Clone,
	{
	let local_id = self.kbuckets.local_key().preimage();
	let others_iter = peers.filter(|p| &p.node_id != local_id);
	if let Some(query) = self.queries.get_mut(query_id) {
	tracing::trace!(peer=%source, query=?query_id, "Request to peer in query succeeded");
	for peer in others_iter.clone() {
	tracing::trace!(
	?peer,
	%source,
	query=?query_id,
	"Peer reported by source in query"
	);
	let addrs = peer.multiaddrs.iter().cloned().collect();
	query.peers.addresses.insert(peer.node_id, addrs);
	}
	query.on_success(source, others_iter.map(|kp| kp.node_id))
	}
	}

[clovas]

If I have understood the situation correctly, we should remove duplicates and aggregate them, as this represents the result of a single query.