Skip to content

Commit 4d476b2

Browse files
committed
ci: drop helm-e2e's wait on the deleted ActorTemplate CRD
helm-e2e waited for condition=Ready on the counter-microvm ActorTemplate CRD after deploying the demo. The cutover to the substrate ActorTemplate proto removed the CRD golden flow and then the CRD itself, so the wait can never succeed. The demo deploy now creates the substrate template and waits for its golden snapshot internally, so drop the separate wait step and point the micro-VM test lane at the substrate fixtures with the E2E_SANDBOX_CLASS knob pr-workflow already uses.
1 parent 196919e commit 4d476b2

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/helm-e2e.yaml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ jobs:
8686
--reuse-values \
8787
--wait --timeout=10m
8888
- name: Deploy micro-VM counter demo
89+
# The deploy creates the substrate ActorTemplate and waits for its golden
90+
# snapshot internally; the ActorTemplate CRD (and its Ready condition)
91+
# no longer exists to wait on.
8992
run: hack/run-microvm-demo-kind.sh --skip-control-plane
9093
- name: Deploy gVisor counter demo
9194
run: hack/install-ate-kind.sh --deploy-demo-counter
@@ -95,9 +98,7 @@ jobs:
9598
run: hack/run-e2e-kind.sh -v -args --no-color
9699
- name: Run E2E tests (micro-VM)
97100
env:
98-
E2E_TEMPLATE_NAMESPACE: ate-demo-counter-microvm
99-
E2E_TEMPLATE_NAME: counter-microvm
100-
E2E_TEMPLATE_READY_TIMEOUT: 600s
101+
E2E_SANDBOX_CLASS: microvm
101102
run: hack/run-e2e-kind.sh ./internal/e2e/suites/demo -v -args --no-color
102103
- name: Dump diagnostics on failure
103104
if: failure()

0 commit comments

Comments
 (0)