From c85096bc8c2761b534ac8e24b5685976d891bd1b Mon Sep 17 00:00:00 2001 From: Kush Zingade Date: Tue, 25 Aug 2026 01:54:10 +0800 Subject: [PATCH] docs: note tests/smoketest.sh is not run by any CI workflow docs/ci.md pointed at tests/smoketest.sh without saying whether CI runs it. It doesn't: smoke.yaml runs tox -e py3-smoke, which only invokes pytest tests/smoke, never smoketest.sh. The script still covers axes the pytest matrix doesn't (flash-attention, Granite, FSDP+LoRA), so it's orphaned rather than redundant. Notes that explicitly and points at #705 where the consolidation question is still open. Ref: https://github.com/instructlab/training/issues/705 Co-Authored-By: Claude Fable 5 Signed-off-by: Kush Zingade --- docs/ci.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ci.md b/docs/ci.md index fdd0fb6d..98a4f4e2 100644 --- a/docs/ci.md +++ b/docs/ci.md @@ -16,7 +16,7 @@ In CI, the tests are run with Python 3.11 - 3.13 on Ubuntu and MacOS runners - y Some smoke tests currently live in the `tests/smoke` directory and are run with [pytest](https://docs.pytest.org/) via [tox](https://tox.wiki/). -There is also a Shell-based smoke test script that can be found at `tests/smoketest.sh`. +There is also a Shell-based smoke test script that can be found at `tests/smoketest.sh`. It is **not currently run by any CI workflow** (`smoke.yaml` only invokes `tox -e py3-smoke`, which points at `tests/smoke/`) — see [#705](https://github.com/instructlab/training/issues/705) for the coverage this script still exercises (flash-attention on/off, Granite on/off, FSDP+LoRA) that the pytest matrix does not. To run the smoke tests, you can run `tox -e py3-smoke`