Skip to content

Move polar panel-border blanking into themeable.py #3

@iangow

Description

@iangow

Upstream PR review item from has2k1#1059.

Source review thread:

Requested change:

  • Move the polar spine blanking logic out of ggplot.py and into plotnine/themes/themeable.py.
  • Implement the behavior in the panel_border themeable, for example by checking whether "polar" in ax.spines and hiding ax.spines["polar"] when blanking the panel border.

Review goal: keep theme behavior in themeables instead of adding coordinate-specific theme handling in ggplot.py.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions