Upstream PR review item from has2k1#1059.
Source review thread:
Requested change:
- Move the polar spine blanking logic out of
ggplot.py and into plotnine/themes/themeable.py.
- Implement the behavior in the
panel_border themeable, for example by checking whether "polar" in ax.spines and hiding ax.spines["polar"] when blanking the panel border.
Review goal: keep theme behavior in themeables instead of adding coordinate-specific theme handling in ggplot.py.
Upstream PR review item from has2k1#1059.
Source review thread:
coord_polarandcoord_radial. has2k1/plotnine#1059 (comment)Requested change:
ggplot.pyand intoplotnine/themes/themeable.py.panel_borderthemeable, for example by checking whether"polar" in ax.spinesand hidingax.spines["polar"]when blanking the panel border.Review goal: keep theme behavior in themeables instead of adding coordinate-specific theme handling in
ggplot.py.