Skip to content

Commit 5027b36

Browse files
michaelnebelmichaelnebel
authored
Merge pull request #22265 from JarLob/aspnetcore-controller-discovery
C#: Improve ASP.NET Core MVC controller discovery
2 parents e9caa4e + 61ec80f commit 5027b36

36 files changed

Lines changed: 610 additions & 64 deletions

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/AttributeWebApp/AttributePocoController.cs‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
using Microsoft.AspNetCore.Mvc;
2+
3+
[Route("api/attribute")]
4+
public class AttributePocoController
5+
{
6+
[HttpGet]
7+
public void Action(string input) => _ = GetType().Name + input;
8+
}

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/AttributeWebApp/AttributeWebApp.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<Project Sdk="Microsoft.NET.Sdk.Web">
2+
<PropertyGroup>
3+
<TargetFramework>net10.0</TargetFramework>
4+
</PropertyGroup>
5+
</Project>

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/AttributeWebApp/ConventionOnlyController.cs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
public class ConventionOnlyController
2+
{
3+
public void Action(string input) => _ = GetType().Name + input;
4+
}

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/AttributeWebApp/Program.cs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
using Microsoft.AspNetCore.Builder;
2+
using Microsoft.Extensions.DependencyInjection;
3+
4+
var builder = WebApplication.CreateBuilder(args);
5+
builder.Services.AddControllers();
6+
7+
var app = builder.Build();
8+
app.MapControllers();
9+
app.Run();

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/Controllers.expected‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
| AdminAreaFallbackController.cs | AreaFallbackController |
2+
| AttributePocoController.cs | AttributePocoController |
3+
| FallbackOnlyController.cs | FallbackOnlyController |
4+
| GeneratedController.cs | GeneratedController |
5+
| IncludedController.cs | IncludedController |
6+
| StructuralController.cs | StructuralController |
7+
| WebPocoController.cs | WebPocoController |

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/Controllers.ql‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import csharp
2+
import semmle.code.csharp.frameworks.microsoft.AspNetCore
3+
4+
from MicrosoftAspNetCoreMvcController controller
5+
where controller.fromSource()
6+
select controller.getFile().getBaseName(), controller.getName()

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/GeneratedControllers/GeneratedController.cs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
namespace GeneratedControllers;
2+
3+
public class GeneratedController
4+
{
5+
public void Action(string input) => _ = GetType().Name + input;
6+
}

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/GeneratedControllers/GeneratedControllers.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<Project Sdk="Microsoft.NET.Sdk">
2+
<PropertyGroup>
3+
<TargetFramework>net10.0</TargetFramework>
4+
</PropertyGroup>
5+
</Project>

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/IncludedControllers/IncludedController.cs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
namespace IncludedControllers;
2+
3+
public class IncludedController
4+
{
5+
public void Action(string input) => _ = GetType().Name + input;
6+
}

‎csharp/ql/integration-tests/all-platforms/aspnetcore_controller_discovery/IncludedControllers/IncludedControllers.csproj‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<Project Sdk="Microsoft.NET.Sdk">
2+
<PropertyGroup>
3+
<TargetFramework>net10.0</TargetFramework>
4+
</PropertyGroup>
5+
</Project>

0 commit comments

Comments
 (0)