Skip to content

Commit 1d59e69

Browse files
committed
C#: Document ASP.NET Core controller discovery
1 parent 17d4936 commit 1d59e69

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* Improved ASP.NET Core MVC controller and action discovery to more closely match runtime behavior, including application parts, endpoint mappings, inherited actions, and controller and action exclusions. Service-injected action parameters are no longer modeled as remote input.

‎csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,9 +388,12 @@ class MicrosoftAspNetCoreMvcControllerHelperClass extends Class {
388388
}
389389

390390
/**
391-
* A valid ASP.NET Core controller according to:
392-
* https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/actions?view=aspnetcore-3.1
393-
* https://github.com/dotnet/aspnetcore/blob/b3c93967ba508b8ef139add27132d9483c1a9eb4/src/Mvc/Mvc.Core/src/Controllers/ControllerFeatureProvider.cs#L39-L75
391+
* An ASP.NET Core MVC controller, as described by:
392+
* https://learn.microsoft.com/en-us/aspnet/core/mvc/controllers/actions
393+
* https://learn.microsoft.com/en-us/aspnet/core/mvc/advanced/app-parts
394+
* https://learn.microsoft.com/en-us/aspnet/core/mvc/controllers/routing
395+
* https://github.com/dotnet/aspnetcore/blob/747d2cdb584079a0c7309115979f13c331fb7df7/src/Mvc/Mvc.Core/src/Controllers/ControllerFeatureProvider.cs#L20-L75
396+
* https://github.com/dotnet/aspnetcore/blob/747d2cdb584079a0c7309115979f13c331fb7df7/src/Mvc/Mvc.Core/src/ApplicationModels/DefaultApplicationModelProvider.cs#L410-L459
394397
*/
395398
class MicrosoftAspNetCoreMvcController extends Class {
396399
MicrosoftAspNetCoreMvcController() { isDefaultMicrosoftAspNetCoreMvcController(this) }

0 commit comments

Comments
 (0)