Fix NumberFormatException with very large numbers in ArrayMap#577
Open
veeti wants to merge 1 commit into
Open
Conversation
Test case names containing long numbers could result in a NumberFormatException being thrown. Support arbitrarily large numbers by comparing strings.
Member
|
IIUC, this helps once there are more than 2,147,483,647 snapshots. If each snapshot has size of only 1 byte, this would be ~2Gb of snapshot data (not counting indirection). I would guess ~10GB in RAM, even if the data was only a single byte being snapshotted. Do you have a usecase where you need this? How did you choose to work on this change? |
Author
|
I am hitting this from my Kotest suite. This reproducer should demonstrate: class ArrayMapNumberFormatTest : DescribeSpec({
it("a123") {}
it("a${Long.MAX_VALUE}") {}
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case names containing long numbers could result in a NumberFormatException being thrown. Support arbitrarily large numbers by comparing strings.