fix: add audited PaymentEscrow reference contract and security docs (closes #86, #85)#121
Open
demarco2016 wants to merge 3 commits into
Open
fix: add audited PaymentEscrow reference contract and security docs (closes #86, #85)#121demarco2016 wants to merge 3 commits into
demarco2016 wants to merge 3 commits into
Conversation
Closes: circlefin#86 (PaymentEscrow 4 vulnerabilities) Closes: circlefin#85 (SVG tokenURI stored XSS) - Add PaymentEscrow.sol with fixes for all 4 vulns: - V1: cap releaseDelay to 90 days (overflow guard) - V2: payee as unconditional release authority - V3: snapshot feeBpsAtFund at escrow funding time - V4: Ownable2Step to prevent ownership lockout - Add docs/building-payment-contracts.md security guide - Add docs/svg-tokenuri-security.md with safe rendering snippets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two security issues reported in #86 and #85:
#86 — PaymentEscrow Vulnerabilities (4 fixes)
Adds a fully audited reference PaymentEscrow contract plus a security guide.
#85 — SVG tokenURI Stored XSS
Adds docs warning against dangerouslySetInnerHTML for on-chain SVG rendering, with safe alternatives.
Files
Closes #86
Closes #85