feature: remove construct from interfaces (#132)

For better SOLID patterns compliance (Liskov)

Author: vgreb

CHANGELOG

@@ -1,3 +1,6 @@
+4.0.0-rc.2 (unreleased):
+    * Remove constructors from Interfaces (Liskov Substitution Principle violation)
+
 4.0.0-rc.1 (2025-12-15):
     * BC PHP 8.0 dropped, minimum version is now PHP 8.1
     * BC All classes now fully typehinted with strict types and return types

src/Ting/ConnectionPoolInterface.php

@@ -30,11 +30,6 @@
 
 interface ConnectionPoolInterface
 {
-    /**
-     * @param DriverLoggerInterface $logger
-     */
-    public function __construct(DriverLoggerInterface $logger);
-
     public function setConfig(array $config): void;
 
     /**

src/Ting/Driver/StatementInterface.php

@@ -31,14 +31,6 @@
 
 interface StatementInterface
 {
-    /**
-     * @param mysqli_stmt|Object $driverStatement
-     * @param array               $paramsOrder
-     * @param string              $connectionName
-     * @param string              $database
-     */
-    public function __construct($driverStatement, array $paramsOrder, string $connectionName, string $database);
-
     /**
      * @param array $params
      * @throws QueryException

src/Ting/Query/QueryInterface.php

@@ -34,13 +34,6 @@
  */
 interface QueryInterface
 {
-    /**
-     * @param string $sql
-     * @param Connection $connection
-     * @param CollectionFactoryInterface $collectionFactory
-     */
-    public function __construct($sql, Connection $connection, ?CollectionFactoryInterface $collectionFactory = null);
-
     /**
      * Execute a reading query (SELECT, SHOW, etc.)
      * @param CollectionInterface<T>|null $collection

tests/units/Ting/Repository/Metadata.php

@@ -693,7 +693,7 @@ public function testGenerateQueryForInsertShouldReturnAPreparedQuery()
         $mockConnection = new \mock\CCMBenchmark\Ting\Connection($mockConnectionPool, 'main', 'db');
 
         $mockDriver = new \mock\tests\fixtures\FakeDriver\Driver();
-        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface(new \stdClass(), [], '', '');
+        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface();
         $this->calling($mockDriver)->prepare = $mockStatement;
         $this->calling($mockDriver)->execute = true;
         $this->calling($mockStatement)->execute = true;
@@ -960,7 +960,7 @@ public function testGenerateQueryForUpdateShouldReturnAPreparedQuery()
     {
         $mockConnectionPool = new \mock\CCMBenchmark\Ting\ConnectionPool();
         $mockDriver = new \mock\tests\fixtures\FakeDriver\Driver();
-        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface(new \stdClass(), [], '', '');
+        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface();
         $this->calling($mockDriver)->prepare = $mockStatement;
         $this->calling($mockDriver)->execute = true;
         $this->calling($mockStatement)->execute = true;
@@ -1018,7 +1018,7 @@ public function testGenerateQueryForDeleteShouldReturnAPreparedQuery()
     {
         $mockConnectionPool = new \mock\CCMBenchmark\Ting\ConnectionPool();
         $mockDriver = new \mock\tests\fixtures\FakeDriver\Driver();
-        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface(new \stdClass(), [], '', '');
+        $mockStatement = new \mock\CCMBenchmark\Ting\Driver\StatementInterface();
         $this->calling($mockDriver)->prepare = $mockStatement;
         $this->calling($mockDriver)->execute = true;
         $this->calling($mockStatement)->execute = true;