Skip to content

vehicle-setup: lights: properly handle dedicated output functions #3976

Description

@ES-Alexander

Current behaviour

The Vehicle Setup "Lights" management page has not yet been updated to handle the dedicated Lights1/2 SERVOn_FUNCTION parameter values that were introduced in ArduSub 4.5.6, so it currently still sets the old RCIN9/10 values (which the firmware auto-corrects to the new values on reboot), and also looks for those values (so correctly configured lights don't get detected):

Image

Showing and setting incorrect configurations is confusing for users, and causes mistrust of BlueOS as a viable configuration tool. We should resolve this before any major push to transition users from QGC to BlueOS for configuration, ideally as part of 1.4.4.

Expected or desired behaviour

  1. The Lights page should be updated to only mention RCIN9/10 when the detected firmware version is <= 4.5.5, and otherwise should look for and set the dedicated Lights1/2 values instead
    • The updated searching should also be applied to the lights info in the main Vehicle Setup page
  2. Alternatively, the interface could be set to assume the dedicated outputs only, and provide an upgrade warning to users with an older firmware version (instead of maintaining the old configuration options)

For reference, the PWM Outputs page was updated (in #3860 and #3875) to account for the change in firmware behaviour, but we forgot about the other pages that involve the lights configuration.

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.

Metadata

Metadata

Labels

P1 - Important PriorityHigh priority taskcoreIssue related to BlueOS-coreenhancementNew feature or requestuiUser Interface feature

Type

No type

Fields

Priority

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions