Skip to content

Consider adding KDF and salt to password encryption #1

Description

@Gustav-Simonsson

Currently the AES key is SHA256 of the user entered password. To make it harder for an attacker who gets hold of an encrypted key file, SHA256 can be replaced by a strong KDF which also uses a salt.

This would make it significantly harder to brute force decryption of weaker passwords.

Here is a example using scrypt and a cryptographically strong salt: https://github.com/ethereum/go-ethereum/blob/develop/crypto/key_store_passphrase.go#L117

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions