fix(postgres): failed loudly on a plain-SQL restore error

A plain-format restore ran `psql --quiet` without ON_ERROR_STOP, so psql
swallowed per-statement errors and still exited 0. Restoring a plain dump onto a
non-empty database (e.g. a live instance whose schema was already created on
boot) therefore reported success while restoring little or nothing.

Added `--set ON_ERROR_STOP=1` to both plain psql branches so the first failed
statement aborts with a non-zero exit, which the runner surfaces as a failed
restore. No change on the intended fresh/empty-DB path. Surfaced by the NocoDB
two-mode restore audit (DB-mode strategy).

Author: karlspace

src/backuphelper/sources/postgres.py

@@ -106,9 +106,12 @@ def build_restore_argv(cfg: PostgresConfig, dump: Path) -> list[str]:
     if suffix.endswith(".dump"):
         return ["pg_restore", "--clean", "--if-exists", "--no-owner", "--no-acl",
                 "--single-transaction", "--dbname", cfg.database, str(dump)]
+    # ON_ERROR_STOP=1 makes psql exit non-zero on the first failed statement
+    # instead of swallowing errors and exiting 0 — so a plain-SQL restore onto a
+    # non-empty DB fails loudly instead of reporting a false success.
     if suffix.endswith(".sql.gz"):
-        return ["psql", "--quiet"]  # dump is streamed to stdin (gunzipped)
-    return ["psql", "--quiet", "--file", str(dump)]
+        return ["psql", "--quiet", "--set", "ON_ERROR_STOP=1"]  # dump streamed to stdin (gunzipped)
+    return ["psql", "--quiet", "--set", "ON_ERROR_STOP=1", "--file", str(dump)]
 
 
 def _pg_restore(cfg: PostgresConfig, dump: Path, run: RunFn) -> None:

tests/sources/test_postgres.py

@@ -102,6 +102,17 @@ def test_restore_argv_for_plain_sql():
     assert argv[0] == "psql"
 
 
+def test_plain_restore_stops_on_first_error():
+    # A plain psql restore must fail loudly (ON_ERROR_STOP=1) instead of swallowing
+    # per-statement errors and exiting 0 — otherwise a restore onto a non-empty DB
+    # reports success while restoring nothing.
+    from backuphelper.sources.postgres import build_restore_argv
+    for dump in (Path("/r/database.sql.gz"), Path("/r/database.sql")):
+        argv = build_restore_argv(PostgresSource(_cfg()).cfg, dump)
+        assert argv[0] == "psql"
+        assert "--set" in argv and "ON_ERROR_STOP=1" in argv, argv
+
+
 def test_restore_runs_pg_restore_for_dump(tmp_path):
     # component name defaults to the database name ("logto")
     (tmp_path / "logto.dump").write_bytes(b"x")