Skip to content

Commit 8f43078

Browse files
committed
chore: remove fragile unit tests
1 parent 0498cc7 commit 8f43078

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

‎aws_advanced_python_wrapper/resources/aws_advanced_python_wrapper_messages.properties‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ AdfsCredentialsProviderFactory.SignOnPagePostActionUrl=[AdfsCredentialsProviderF
2626
AdfsCredentialsProviderFactory.SignOnPagePostActionRequestFailed=[AdfsCredentialsProviderFactory] ADFS SignOn Page POST action failed with HTTP status '{}', reason phrase '{}', and response '{}'
2727
AdfsCredentialsProviderFactory.SignOnPageUrl=[AdfsCredentialsProviderFactory] ADFS SignOn URL: '{}'
2828

29-
AwsSdk.UnsupportedRegion=[AwsSdk] Unsupported AWS region {}. For supported regions please read https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.RegionsAndAvailabilityZones.html
29+
AwsSdk.UnsupportedRegion=[AwsSdk] Unsupported AWS region {}. Please check AWS documentation for supported AWS regions.
3030

3131
AwsSecretsManagerPlugin.ConnectException=[AwsSecretsManagerPlugin] Error occurred while opening a connection: {}
3232
AwsSecretsManagerPlugin.EndpointOverrideInvalidConnection=[AwsSecretsManagerPlugin] A connection to the provided secrets_manager_endpoint could not be established: "{}".

‎tests/unit/test_iam_plugin.py‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
from __future__ import annotations
1616

17-
import urllib.request
1817
from datetime import datetime, timedelta
1918

2019
import pytest
@@ -383,12 +382,6 @@ def test_connect_with_specified_host(iam_host: str, mocker, mock_plugin_service,
383382
assert actual_token.is_expired() is False
384383

385384

386-
def test_aws_supported_regions_url_exists():
387-
url = "https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.RegionsAndAvailabilityZones.html"
388-
request = urllib.request.Request(url, headers={"User-Agent": "Mozilla/5.0"})
389-
assert 200 == urllib.request.urlopen(request).getcode()
390-
391-
392385
@pytest.mark.parametrize("host", [
393386
pytest.param("<>"),
394387
pytest.param("#"),

0 commit comments

Comments
 (0)