From d5f3047c340e3504cec62e76128ee70bf0dfd8b4 Mon Sep 17 00:00:00 2001 From: Andrea Amorosi Date: Sat, 5 Sep 2026 00:24:29 +0200 Subject: [PATCH] chore: align CI and repository templates Keep publishable package checks, issue metadata, and RFC guidance aligned with the current repository and organization configuration. Fixes #5631 --- .../{rfcs.yml => rfcs-request-for-comments.yml} | 5 ++++- .github/ISSUE_TEMPLATE/bug_report.yml | 3 ++- .github/ISSUE_TEMPLATE/documentation_improvements.yml | 3 ++- .github/ISSUE_TEMPLATE/feature_request.yml | 3 ++- .github/ISSUE_TEMPLATE/maintenance.yml | 3 ++- .github/workflows/on_pr_updates.yml | 6 +++--- .github/workflows/quality_check.yml | 7 ++++++- .../reusable-run-linting-check-and-unit-tests.yml | 4 +++- CONTRIBUTING.md | 2 +- docs/features/metrics.md | 2 +- docs/roadmap.md | 6 +++--- 11 files changed, 29 insertions(+), 15 deletions(-) rename .github/DISCUSSION_TEMPLATE/{rfcs.yml => rfcs-request-for-comments.yml} (97%) diff --git a/.github/DISCUSSION_TEMPLATE/rfcs.yml b/.github/DISCUSSION_TEMPLATE/rfcs-request-for-comments.yml similarity index 97% rename from .github/DISCUSSION_TEMPLATE/rfcs.yml rename to .github/DISCUSSION_TEMPLATE/rfcs-request-for-comments.yml index 98ed1f9c0a..fd933670af 100644 --- a/.github/DISCUSSION_TEMPLATE/rfcs.yml +++ b/.github/DISCUSSION_TEMPLATE/rfcs-request-for-comments.yml @@ -25,6 +25,9 @@ body: - JMESPath - Batch Processing - Validation + - Kafka + - Data Masking + - Signer - Commons - Automation - Governance @@ -109,4 +112,4 @@ body: attributes: label: Future readers description: Please not edit this field - value: "Please react with 👍 and your use case to help us understand customer demand." \ No newline at end of file + value: "Please react with 👍 and your use case to help us understand customer demand." diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 19d952d231..0a290efe41 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,7 +1,8 @@ name: Bug report description: Report a reproducible bug to help us improve title: "Bug: " -labels: ["bug", "triage"] +labels: ["triage"] +type: Bug body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/documentation_improvements.yml b/.github/ISSUE_TEMPLATE/documentation_improvements.yml index 63aceda5f6..100a6cd533 100644 --- a/.github/ISSUE_TEMPLATE/documentation_improvements.yml +++ b/.github/ISSUE_TEMPLATE/documentation_improvements.yml @@ -1,7 +1,8 @@ name: Documentation improvements description: Suggest a documentation update to improve everyone's experience title: "Docs: <TITLE>" -labels: ["documentation", "triage"] +labels: ["triage"] +type: Task body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 7042148195..ce32c6b049 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,7 +1,8 @@ name: Feature request description: Suggest an idea for Powertools for AWS Lambda title: "Feature request: <TITLE>" -labels: ["feature-request", "triage"] +labels: ["triage"] +type: Enhancement body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/maintenance.yml b/.github/ISSUE_TEMPLATE/maintenance.yml index 60ac59cfb8..b450d9eabd 100644 --- a/.github/ISSUE_TEMPLATE/maintenance.yml +++ b/.github/ISSUE_TEMPLATE/maintenance.yml @@ -1,7 +1,8 @@ name: Maintenance description: Suggest an activity to help address tech debt, governance, and anything internal title: "Maintenance: <TITLE>" -labels: ["internal", "triage"] +labels: ["triage"] +type: Task body: - type: markdown attributes: diff --git a/.github/workflows/on_pr_updates.yml b/.github/workflows/on_pr_updates.yml index acd301f676..42767998cb 100644 --- a/.github/workflows/on_pr_updates.yml +++ b/.github/workflows/on_pr_updates.yml @@ -12,8 +12,8 @@ name: PR requirements # NOTES # -# PR requirements are checked async in on_opened_pr.yml and enforced here synchronously -# due to limitations in GH API. +# Organization-level checks evaluate PR requirements asynchronously; this workflow enforces +# the resulting do-not-merge label synchronously due to limitations in the GitHub API. on: pull_request: @@ -32,4 +32,4 @@ jobs: if: contains(github.event.pull_request.labels.*.name, 'do-not-merge') run: | echo "This PR does not meet minimum requirements (check PR comments)." - exit 1 \ No newline at end of file + exit 1 diff --git a/.github/workflows/quality_check.yml b/.github/workflows/quality_check.yml index 8da900c7ca..52e04758d9 100644 --- a/.github/workflows/quality_check.yml +++ b/.github/workflows/quality_check.yml @@ -21,17 +21,22 @@ jobs: strategy: matrix: version: [22, 24] + # packages/testing is private and intentionally excluded from this publishable package matrix. workspace: [ "packages/batch", "packages/commons", + "packages/data-masking", "packages/event-handler", "packages/idempotency", "packages/jmespath", + "packages/kafka", "packages/logger", "packages/tracer", "packages/parser", "packages/parameters", - "packages/metrics" + "packages/metrics", + "packages/signer", + "packages/validation" ] fail-fast: false steps: diff --git a/.github/workflows/reusable-run-linting-check-and-unit-tests.yml b/.github/workflows/reusable-run-linting-check-and-unit-tests.yml index 1b5b5b643d..6f4522eab1 100644 --- a/.github/workflows/reusable-run-linting-check-and-unit-tests.yml +++ b/.github/workflows/reusable-run-linting-check-and-unit-tests.yml @@ -41,6 +41,7 @@ jobs: strategy: matrix: version: [22, 24] + # packages/testing is private and intentionally excluded from this publishable package matrix. workspace: [ "packages/batch", "packages/commons", @@ -54,7 +55,8 @@ jobs: "packages/parameters", "packages/validation", "packages/metrics", - "packages/kafka" + "packages/kafka", + "packages/signer" ] fail-fast: false steps: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0e8858e695..f3f4b9235e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ - [Licensing](#licensing) <!-- markdownlint-disable MD013 --> -Thank you for your interest in contributing to our project. Whether it's a [bug report](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=type%2Fbug%2Ctriage&projects=aws-powertools%2F7&template=bug_report.yml&title=Bug%3A+TITLE), [new feature](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=type%2Ffeature-request%2Ctriage&projects=aws-powertools%2F7&template=feature_request.yml&title=Feature+request%3A+TITLE), [correction](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new/choose), or [additional documentation](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=area%2Fdocumentation%2Ctriage&projects=aws-powertools%2F7&template=documentation_improvements.yml&title=Docs%3A+TITLE), we greatly value feedback and contributions from our community. +Thank you for your interest in contributing to our project. Whether it's a [bug report](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=triage&projects=aws-powertools%2F7&template=bug_report.yml&title=Bug%3A+TITLE), [new feature](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=triage&projects=aws-powertools%2F7&template=feature_request.yml&title=Feature+request%3A+TITLE), [correction](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new/choose), or [additional documentation](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=triage&projects=aws-powertools%2F7&template=documentation_improvements.yml&title=Docs%3A+TITLE), we greatly value feedback and contributions from our community. <!-- markdownlint-enable MD013 --> We encourage contributions from the community and we will work with contributors to merge their pull requests. diff --git a/docs/features/metrics.md b/docs/features/metrics.md index 5e50ad3a65..a02ce290a3 100644 --- a/docs/features/metrics.md +++ b/docs/features/metrics.md @@ -382,7 +382,7 @@ If it's a cold start invocation, this feature will: This has the advantage of keeping cold start metric separate from your application metrics, where you might have unrelated dimensions. -!!! info "We do not emit 0 as a value for the ColdStart metric for cost-efficiency reasons. [Let us know](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=feature-request%2C+triage&template=feature_request.md&title=) if you'd prefer a flag to override it." +!!! info "We do not emit 0 as a value for the ColdStart metric for cost-efficiency reasons. [Let us know](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=triage&template=feature_request.yml&title=) if you'd prefer a flag to override it." #### Setting function name diff --git a/docs/roadmap.md b/docs/roadmap.md index c294e7921e..8a4597db7b 100644 --- a/docs/roadmap.md +++ b/docs/roadmap.md @@ -98,7 +98,7 @@ To ensure we are attracting tomorrow's customers as well as new contributors to ### Missing something? -You can help us prioritize by [upvoting existing feature requests](https://github.com/aws-powertools/powertools-lambda-typescript/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc++label%3Atype%2Ffeature-request+), leaving a comment on what use cases it could unblock for you, and by joining our discussions on GitHub. +You can help us prioritize by [upvoting existing feature requests](https://github.com/aws-powertools/powertools-lambda-typescript/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+type%3AEnhancement), leaving a comment on what use cases it could unblock for you, and by joining our discussions on GitHub. [![GitHub Discussions](https://img.shields.io/badge/GitHub-Discussions-181717.svg?logo=github)](https://github.com/aws-powertools/powertools-lambda-typescript/discussions) @@ -140,9 +140,9 @@ graph LR Our end-to-end mechanism follows four major steps: -- **Feature Request**. Ideas start with a [feature request](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=type%2Ffeature-request%2Ctriage&template=feature_request.yml&title=Feature+request%3A+TITLE){target="_blank"} to outline their use case at a high level. For complex use cases, maintainers might ask for/write a RFC. +- **Feature Request**. Ideas start with a [feature request](https://github.com/aws-powertools/powertools-lambda-typescript/issues/new?assignees=&labels=triage&template=feature_request.yml&title=Feature+request%3A+TITLE){target="_blank"} to outline their use case at a high level. For complex use cases, maintainers might ask for/write a RFC. - Maintainers review requests based on [project tenets](index.md#tenets){target="_blank"}, customers reaction (👍), and use cases. -- **Request-for-comments (RFC)**. Design proposals use our [RFC template](https://github.com/aws-powertools/powertools-lambda-typescript/discussions/new?category=rfcs){target="_blank"} to describe its implementation, challenges, developer experience, dependencies, and alternative solutions. +- **Request-for-comments (RFC)**. Design proposals use our [RFC template](https://github.com/aws-powertools/powertools-lambda-typescript/discussions/new?category=rfcs-request-for-comments){target="_blank"} to describe its implementation, challenges, developer experience, dependencies, and alternative solutions. - This helps refine the initial idea with community feedback before a decision is made. - **Decision**. After carefully reviewing and discussing them, maintainers make a final decision on whether to start implementation, defer or reject it, and update everyone with the next steps. - **Implementation**. For approved features, maintainers give priority to the original authors for implementation unless it is a sensitive task that is best handled by maintainers.