diff --git a/mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala b/mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala index 181168385011d..ead7b4d27f46d 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala @@ -66,7 +66,7 @@ private[spark] class DecisionTreeMetadata( def isMulticlass: Boolean = numClasses > 2 - def isMulticlassWithCategoricalFeatures: Boolean = isMulticlass && (featureArity.size > 0) + def isMulticlassWithCategoricalFeatures: Boolean = isMulticlass && (featureArity.nonEmpty) def isCategorical(featureIndex: Int): Boolean = featureArity.contains(featureIndex) diff --git a/mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala b/mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala index 5f45cc3315621..b230a18ee0642 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/tree/treeModels.scala @@ -229,7 +229,7 @@ private[ml] object TreeEnsembleModel { maxFeatureIndex + 1 } if (d == 0) { - assert(totalImportances.size == 0, s"Unknown error in computing feature" + + assert(totalImportances.isEmpty, s"Unknown error in computing feature" + s" importance: No splits found, but some non-zero importances.") } val (indices, values) = totalImportances.iterator.toSeq.sortBy(_._1).unzip diff --git a/mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala b/mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala index c1f82157e82f2..ab6c6f7467563 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala @@ -98,7 +98,7 @@ class Strategy @Since("1.3.0") ( */ @Since("1.2.0") def isMulticlassWithCategoricalFeatures: Boolean = { - isMulticlassClassification && (categoricalFeaturesInfo.size > 0) + isMulticlassClassification && (categoricalFeaturesInfo.nonEmpty) } // scalastyle:off argcount diff --git a/mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala index a5bff057bfec8..58cc9900d90de 100644 --- a/mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala +++ b/mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala @@ -995,8 +995,8 @@ class ALSSuite extends MLTest with DefaultReadWriteTest with Logging { val shuffledItemFactors = getShuffledDependencies(itemFactors.rdd).filter { dep => dep.rdd.name != null && dep.rdd.name.contains("itemFactors") } - assert(shuffledUserFactors.size == 0) - assert(shuffledItemFactors.size == 0) + assert(shuffledUserFactors.isEmpty) + assert(shuffledItemFactors.isEmpty) } private def checkRecommendations(