Repository navigation
Commit 3a89171
authored
fix(memory): never inject a recalled procedure cut mid-step as proven (#6334)
A recalled procedure longer than the 1500-character budget was sliced at
a raw character offset and still shown to the model as a "proven
procedure" to reuse, so a small local model could confidently run the
first few steps of a procedure and skip the later cleanup and
verification it never saw. Now a long procedure is never cut mid-step:
it is left out when a complete, better-matching procedure is already
shown, and otherwise cut at the last step/heading/paragraph boundary,
marked `INCOMPLETE`, and the header tells the model to plan the missing
steps itself. Each cut or drop is logged so its frequency is visible,
and the common case (every procedure fits) produces a byte-identical
block, so prompt caching is unaffected.
Product choice: drop-vs-truncate follows rank — an over-cap procedure is
dropped only when a complete higher-ranked one is already in the block;
the best match is never dropped, only cut and marked.
**Eval required before merge:** this changes the recalled-procedure text
the model sees. Dispatch `eval_flagship.yml` for `gaia_memory`, `memory`
and `gaia_skills_capture`.
Fixes #2676
## Test plan
- [x] `python -m pytest tests/unit/test_memory_mixin.py -q` — 364 passed
(new cases: byte-identical under-cap block, exact-cap boundary,
step-boundary cut, drop vs cut by rank, two over-cap bodies, single
giant step, unstructured prose, `3.5 GB` mid-line not a boundary,
paragraph break, logging)
- [x] black / isort / flake8 clean on touched files
- [ ] `eval_flagship.yml` on `gaia_memory`, `memory`,
`gaia_skills_capture` shows no regression vs the flagship baseline1 parent 8810e42 commit 3a89171
4 files changed
Lines changed: 239 additions & 19 deletions
File tree
- docs
- plans
- sdk/sdks
- src/gaia/agents/base
- tests/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
227 | | - | |
228 | | - | |
229 | | - | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
230 | 233 | | |
231 | 234 | | |
232 | 235 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
40 | 64 | | |
41 | 65 | | |
42 | 66 | | |
| |||
430 | 454 | | |
431 | 455 | | |
432 | 456 | | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
438 | 467 | | |
439 | 468 | | |
440 | 469 | | |
441 | 470 | | |
442 | 471 | | |
443 | 472 | | |
| 473 | + | |
| 474 | + | |
444 | 475 | | |
445 | 476 | | |
446 | | - | |
447 | | - | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
448 | 499 | | |
449 | 500 | | |
450 | 501 | | |
| |||
455 | 506 | | |
456 | 507 | | |
457 | 508 | | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
458 | 515 | | |
459 | 516 | | |
460 | 517 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4741 | 4741 | | |
4742 | 4742 | | |
4743 | 4743 | | |
4744 | | - | |
4745 | | - | |
4746 | | - | |
| 4744 | + | |
| 4745 | + | |
| 4746 | + | |
| 4747 | + | |
| 4748 | + | |
| 4749 | + | |
| 4750 | + | |
| 4751 | + | |
| 4752 | + | |
| 4753 | + | |
| 4754 | + | |
| 4755 | + | |
| 4756 | + | |
| 4757 | + | |
| 4758 | + | |
| 4759 | + | |
| 4760 | + | |
| 4761 | + | |
| 4762 | + | |
| 4763 | + | |
| 4764 | + | |
| 4765 | + | |
| 4766 | + | |
| 4767 | + | |
| 4768 | + | |
| 4769 | + | |
| 4770 | + | |
| 4771 | + | |
| 4772 | + | |
| 4773 | + | |
| 4774 | + | |
| 4775 | + | |
| 4776 | + | |
| 4777 | + | |
| 4778 | + | |
| 4779 | + | |
| 4780 | + | |
| 4781 | + | |
| 4782 | + | |
| 4783 | + | |
| 4784 | + | |
| 4785 | + | |
| 4786 | + | |
| 4787 | + | |
| 4788 | + | |
| 4789 | + | |
| 4790 | + | |
| 4791 | + | |
| 4792 | + | |
| 4793 | + | |
| 4794 | + | |
| 4795 | + | |
| 4796 | + | |
| 4797 | + | |
| 4798 | + | |
| 4799 | + | |
| 4800 | + | |
| 4801 | + | |
| 4802 | + | |
| 4803 | + | |
| 4804 | + | |
| 4805 | + | |
| 4806 | + | |
| 4807 | + | |
| 4808 | + | |
| 4809 | + | |
| 4810 | + | |
| 4811 | + | |
| 4812 | + | |
| 4813 | + | |
| 4814 | + | |
| 4815 | + | |
| 4816 | + | |
| 4817 | + | |
| 4818 | + | |
| 4819 | + | |
| 4820 | + | |
| 4821 | + | |
| 4822 | + | |
| 4823 | + | |
| 4824 | + | |
| 4825 | + | |
| 4826 | + | |
| 4827 | + | |
| 4828 | + | |
| 4829 | + | |
| 4830 | + | |
| 4831 | + | |
| 4832 | + | |
| 4833 | + | |
| 4834 | + | |
| 4835 | + | |
| 4836 | + | |
| 4837 | + | |
| 4838 | + | |
| 4839 | + | |
| 4840 | + | |
| 4841 | + | |
4747 | 4842 | | |
4748 | | - | |
| 4843 | + | |
| 4844 | + | |
| 4845 | + | |
4749 | 4846 | | |
| 4847 | + | |
| 4848 | + | |
4750 | 4849 | | |
4751 | | - | |
| 4850 | + | |
| 4851 | + | |
| 4852 | + | |
| 4853 | + | |
| 4854 | + | |
| 4855 | + | |
| 4856 | + | |
| 4857 | + | |
| 4858 | + | |
| 4859 | + | |
| 4860 | + | |
| 4861 | + | |
| 4862 | + | |
| 4863 | + | |
4752 | 4864 | | |
4753 | 4865 | | |
4754 | | - | |
4755 | | - | |
4756 | | - | |
| 4866 | + | |
| 4867 | + | |
| 4868 | + | |
| 4869 | + | |
| 4870 | + | |
| 4871 | + | |
| 4872 | + | |
| 4873 | + | |
| 4874 | + | |
| 4875 | + | |
| 4876 | + | |
| 4877 | + | |
| 4878 | + | |
| 4879 | + | |
| 4880 | + | |
| 4881 | + | |
| 4882 | + | |
| 4883 | + | |
| 4884 | + | |
| 4885 | + | |
| 4886 | + | |
| 4887 | + | |
| 4888 | + | |
| 4889 | + | |
| 4890 | + | |
| 4891 | + | |
| 4892 | + | |
| 4893 | + | |
| 4894 | + | |
| 4895 | + | |
| 4896 | + | |
| 4897 | + | |
| 4898 | + | |
| 4899 | + | |
| 4900 | + | |
| 4901 | + | |
| 4902 | + | |
| 4903 | + | |
| 4904 | + | |
| 4905 | + | |
| 4906 | + | |
| 4907 | + | |
| 4908 | + | |
| 4909 | + | |
| 4910 | + | |
| 4911 | + | |
| 4912 | + | |
| 4913 | + | |
| 4914 | + | |
| 4915 | + | |
| 4916 | + | |
4757 | 4917 | | |
4758 | 4918 | | |
4759 | 4919 | | |
| |||
0 commit comments