Skip to content

feat(data_export): register PolarDB For MySQL and OceanBase For Oracle as supported DB types#617

Merged
BugsGuru merged 1 commit into
mainfrom
dms/feat-2815
May 19, 2026
Merged

feat(data_export): register PolarDB For MySQL and OceanBase For Oracle as supported DB types#617
BugsGuru merged 1 commit into
mainfrom
dms/feat-2815

Conversation

@LordofAvernus
Copy link
Copy Markdown
Collaborator

@LordofAvernus LordofAvernus commented May 13, 2026

User description

Summary

  • Register DBTypePolarDBForMySQL and DBTypeOceanBaseOracle as new DB type constants
  • Add both types to ParseDBType function and supportedDataExportDBTypes map
  • Enables data export support for PolarDB For MySQL and OceanBase For Oracle instances

Fixes https://github.com/actiontech/sqle-ee/issues/2815


Description

  • 注册PolarDB For MySQL常量

  • 新增OceanBase For Oracle常量

  • 更新ParseDBType函数新增分支条件

  • 更新supportedDataExportDBTypes映射,支持新类型


Diagram Walkthrough

flowchart LR
  A["更新ParseDBType函数"] -- "添加PolarDB For MySQL分支" --> B["返回DBTypePolarDBForMySQL"]
  A -- "添加OceanBase For Oracle分支" --> C["返回DBTypeOceanBaseOracle"]
  D["更新DB类型常量"] -- "新增OceanBase For Oracle常量" --> E["支持数据导出"]
Loading

File Walkthrough

Relevant files
Enhancement
const.go
修改函数和常量支持新数据库类型                                                                                   

internal/dms/pkg/constant/const.go

  • 修改ParseDBType函数,调整数据库类型判断逻辑
  • 替换DBTypePolarDBMySQL为DBTypePolarDBForMySQL
  • 新增对OceanBase For Oracle的支持分支
  • 更新supportedDataExportDBTypes映射以包含新类型
+9/-5     

@actiontech-bot actiontech-bot requested a review from iwanghc May 13, 2026 09:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

PR Reviewer Guide 🔍

(Review updated until commit 4af926f)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit ca4678b

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 7fe0d70

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions
Copy link
Copy Markdown

Persistent review updated to latest commit 4af926f

@github-actions
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@BugsGuru BugsGuru merged commit 0d48957 into main May 19, 2026
1 check passed
@BugsGuru BugsGuru deleted the dms/feat-2815 branch May 19, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants