update gold standard for err and load#814
Conversation
|
The gold files do not change for different version of the O.S. If there are differences, it is handled by the filter. Many of the differences you are seeing because there are changes in the warning/error messages between Lmod 8.7+ and Lmod 9.2+. If there is an issue with the tests, you will have to upgrade to the latest version of Lmod 9.2+ and rerun the tests. |
|
I did that running 9.2 |
|
Please see the discussion seen in Issue #821. If you have time please rerun your issue with Lmod 9.2.1. |
|
The help test case is fixed in 9.2.1, I only have to add
as our sandbox inject libsandbox in the LD_PRELOAD for the load test I still have problem: |
|
After looking at your new diff. It is clear that Lmod 9.2.1 is generating an error called "e_FAILED_LOAD" and you are generating an error called "e_FAILED_LOAD_2". They are different error because Lmod is not following the same path on your machine and mine. It is not that the gold file I have uploaded Lmod 9.2.2 which fixes the issue with the help test. It now checks that ld_preload has a value and does not care what the value is. To resolve this issue requires that I be able to reproduce it. There are a couple of ways to handle this:
To help me debug, you would have to do the following steps
This may take a few iterations of you downloading new versions of Lmod and redoing steps 1-3 |
|
Strange, for me the 9.2.1 version from gentoo/gentoo#46278 worked fine with Gentoo Prefix and passed all the tests, while for the one that you actually merged (gentoo/gentoo@346253a, with additional patches) the |
I guess some of the dependency have different version. I work with stable tree, except the things I am working on |
|
t1.zip |
|
The tests did not run correctly: Somehow your test setup did not find luaposix. Can you add it? Is there something I can do? |
|
I have now luaposix installed. |
|
Maybe during the test there is a PATH cleanup? This is put in front of the PATH /var/tmp/portage/sys-cluster/lmod-9.2.2/temp/lua5.1/bin to have the selected lua chosen |
|
I am not sure what you are saying. One point I want to check is: the version of lua and having luaposix installed must match. If you have Lua 5.1 installed and then install luaposix with lua 5.1, you can't use lua 5.3 with the luaposix built with Lua 5.1 What do you mean when you say that the test passes with Lua 5.1? Does |
|
In gentoo we can have more then one version of lua. On my system I have: luaposix is built with lua5.1: |
|
I would like to go back to the original issue. While unlikely, the load test does change $PATH. So this might have caused a problem with different version of lua run. To get around this possible problem I have change the modulefiles so that any path that the modules add start with "/unknown". I have also modified the load.tdesc to generate debug info when run. This means that the test cannot pass. However it will lead to debugging info that I can use to figure what the issue might be. Please run your regular install and test with the IS814-gentoo branch of Lmod. Then please make a zip file of the rt/load/t1 directory tree. and attach that here. |
|
t1-lua5.1.zip I can also add the result for when lmod is build with lua5.3 where the global lua is 5.1 or 5.3. Just ask if you need it |
Here (gentoo) some tests does not pass as the err file is different.
This commit fix it here