Skip to content

Commit 8791cd8

Browse files
committed
fix(dev): Register static assets at target path for relative src paths
Static assets were registered at target/identifier/file (e.g., target/assets/file), but relative paths like src='./cat.png' resolve to target/file. Changes: 1. Dev server: Register assets at target/file instead of target/identifier/file 2. Deploy: Add destination: 'assets' so assets copy to assets/ subdirectory Fixes #5285
1 parent 3a92d03 commit 8791cd8

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

packages/app/src/cli/models/extensions/specifications/ui_extension.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ const uiExtensionSpec = createExtensionSpecification({
113113
anchor: 'extension_points[]',
114114
groupBy: 'target',
115115
key: 'extension_points[].assets',
116+
destination: 'assets',
116117
},
117118
{
118119
type: 'configKey',

packages/app/src/cli/services/dev/extension/payload.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -418,8 +418,8 @@ describe('getUIExtensionPayload', () => {
418418
},
419419
},
420420
])
421-
expect(resolver.get('CUSTOM_EXTENSION_POINT/assets/foo.json')).toBe('foo.json')
422-
expect(resolver.get('CUSTOM_EXTENSION_POINT/assets/subdir/bar.png')).toBe('subdir/bar.png')
421+
expect(resolver.get('CUSTOM_EXTENSION_POINT/foo.json')).toBe('foo.json')
422+
expect(resolver.get('CUSTOM_EXTENSION_POINT/subdir/bar.png')).toBe('subdir/bar.png')
423423
})
424424
})
425425

@@ -473,8 +473,8 @@ describe('getUIExtensionPayload', () => {
473473
},
474474
])
475475
// Both targets' resolver entries point at the same output-relative file.
476-
expect(resolver.get('TARGET_A/assets/foo.json')).toBe('foo.json')
477-
expect(resolver.get('TARGET_B/assets/foo.json')).toBe('foo.json')
476+
expect(resolver.get('TARGET_A/foo.json')).toBe('foo.json')
477+
expect(resolver.get('TARGET_B/foo.json')).toBe('foo.json')
478478
})
479479
})
480480

packages/app/src/cli/services/dev/extension/payload.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ async function staticAssetsMapper(
252252
if (files.length === 0) return {}
253253
const urlSubpath = `${target}/${identifier}`
254254
for (const file of files) {
255-
resolver?.set(`${urlSubpath}/${file}`, file)
255+
resolver?.set(`${target}/${file}`, file)
256256
}
257257
const updatedTimestamps = await Promise.all(
258258
files.map(async (file) => (await fileLastUpdatedTimestamp(joinPath(buildDirectory, file))) ?? 0),

0 commit comments

Comments
 (0)