replace by a reusable logger

[github-actions]

📝 Found in ee/packages/federation-matrix/src/helpers/getThreadMessageId.ts#L5

Commit: 74f50d1

[coderabbitai]

🔗 Related PRs

#41046 - fix(federation): edited and deleted messages corrupting event tree [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[Pr241singh]

@coderabbitai I'd like to work on this.

My understanding is that the goal is to replace the duplicated new Logger('federation-matrix:message') instances with a shared reusable logger. I'm planning to extract it into a shared logger.ts for the federation-matrix package and update both events/message.ts and helpers/getThreadMessageId.ts to use it.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '=== Issue `#41452` ==='
gh issue view 41452 --repo RocketChat/Rocket.Chat --json number,title,body,state,url

printf '%s\n' '=== Candidate files ==='
fd -t f -a 'message\.ts|getThreadMessageId\.ts|logger\.ts' . \
  | rg 'federation-matrix|events|helpers' || true

printf '%s\n' '=== Federation-matrix outlines ==='
fd -t d -a 'federation-matrix' . -d 8 | while IFS= read -r dir; do
  ast-grep outline "$dir" --items all --type function,class --view compact 2>/dev/null || true
done

printf '%s\n' '=== Logger construction and relevant imports ==='
rg -n -C 4 "new Logger\('federation-matrix:message'\)|from ['\"].*logger|Logger" \
  -g 'message.ts' -g 'getThreadMessageId.ts' -g 'logger.ts' .

Length of output: 17979

---

@Pr241singh, your understanding is correct.

Please add a shared package-level logger (for example, ee/packages/federation-matrix/src/logger.ts) that exports:

export const logger = new Logger('federation-matrix:message');

Then update both events/message.ts and helpers/getThreadMessageId.ts to import it, remove their local Logger imports/instances, and remove the TODO in getThreadMessageId.ts.

Keep src/api/logger.ts unchanged—it serves the distinct FederationMatrixAPI logging scope.