[FIX] base_import_match: fix name reporting and cache invalidation

- load() no longer mutates the fields/data list passed in by core. Work
  on local copies so the import success screen reports names correctly
  instead of match values (e.g. emails).
- Invalidate the _usable_rules ormcache on create/write/unlink of match
  rules and their fields, so programmatic imports don't use stale rules.
- Make the Match column tooltip translatable (bind via _t).
- Add a regression test covering the name-reporting fix.

Author: AungKoKoLin1997

base_import_match/models/base.py

@@ -70,13 +70,16 @@ def load(self, fields, data):
             self.env["base_import.match"]._usable_rules(self._name, fields)
         )
         if match_only_fields or has_rules:
+            # Work on local copies so we don't mutate the caller's lists
+            # (core reuses them after load() to report imported record names).
+            fields = list(fields)
+            data = [list(row) for row in data]
             newdata = list()
             match_errors = []
             # Change .id (dbid) by id (xmlid)
             if ".id" in fields:
                 column = fields.index(".id")
                 fields[column] = "id"
-                # data[0][column] = "id"
                 for values in data:
                     dbid = int(values[column])
                     values[column] = self.browse(dbid).get_external_id().get(dbid)

base_import_match/models/base_import.py

@@ -9,8 +9,30 @@
 _logger = logging.getLogger(__name__)
 
 
+class BaseImportMatchCacheMixin(models.AbstractModel):
+    _name = "base_import.match.cache.mixin"
+    _description = "Invalidate the _usable_rules cache on rule changes"
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        records = super().create(vals_list)
+        self.env.registry.clear_cache()
+        return records
+
+    def write(self, vals):
+        res = super().write(vals)
+        self.env.registry.clear_cache()
+        return res
+
+    def unlink(self):
+        res = super().unlink()
+        self.env.registry.clear_cache()
+        return res
+
+
 class BaseImportMatch(models.Model):
     _name = "base_import.match"
+    _inherit = "base_import.match.cache.mixin"
     _description = "Deduplicate settings prior to CSV imports."
     _order = "sequence, name"
 
@@ -150,6 +172,7 @@ def _usable_rules(self, model_name, fields):
 
 class BaseImportMatchField(models.Model):
     _name = "base_import.match.field"
+    _inherit = "base_import.match.cache.mixin"
     _description = "Field import match definition"
 
     name = fields.Char(related="field_id.name")

base_import_match/static/src/import_data_content.esm.js

@@ -2,10 +2,16 @@
 // License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 import {ImportDataContent} from "@base_import/import_data_content/import_data_content";
+import {_t} from "@web/core/l10n/translation";
 import {patch} from "@web/core/utils/patch";
 
 patch(ImportDataContent.prototype, {
     onMatchOnlyChanged: (column, ev) => (column.matchOnly = ev.target.checked),
+    get matchColumnTooltip() {
+        return _t(
+            "Use this field to find existing records without updating its value."
+        );
+    },
     get hasIdColumn() {
         return this.props.columns.some(
             (c) => c.fieldInfo && ["id", ".id"].includes(c.fieldInfo.fieldPath)

base_import_match/static/src/import_data_content.xml

@@ -11,7 +11,7 @@
                 scope="col"
                 class="text-nowrap"
                 style="min-width: 0 !important; width: auto;"
-                title="Use this field to find existing records without updating its value."
+                t-att-title="matchColumnTooltip"
             >Match</th>
         </xpath>
         <xpath expr="//td[.//t[@t-foreach='column.comments']]" position="before">

base_import_match/tests/test_import.py

@@ -186,6 +186,28 @@ def test_match_only_from_ui(self):
         self.assertEqual(partner.function, "New Function")
         self.assertEqual(partner.email, "match@example.com")
 
+    def test_match_only_name_reporting(self):
+        """A match-only column before ``name`` must not corrupt result['name'].
+
+        Core reports imported record names by indexing the original columns it
+        passed to ``load()``; dropping the match-only column in place would shift
+        that index and surface the match value (email) instead of the name.
+        """
+        partner = self.Partner.create(
+            {"name": "Report Original", "email": "report@example.com"}
+        )
+        record = self._base_import_record(
+            "res.partner", data="report@example.com,Report Changed\n"
+        )
+        options = dict(OPTIONS, import_match_only_fields=["email"])
+        result = record.execute_import(["email", "name"], [], options)
+        partner.env.cache.invalidate()
+        # The DB write targets the right column...
+        self.assertEqual(partner.name, "Report Changed")
+        # ...and the reported name is the name column, not the match-only email.
+        self.assertEqual(result["name"][0], "Report Changed")
+        self.assertNotIn("report@example.com", result["name"])
+
     def test_match_only_no_match_blocks(self):
         """When match-only field doesn't find a record, block the import."""
         record = self._base_import_record(