send-backup does not detect newly added files in backup set

[filippocarletti]

send-backup checks for file-content changes using the list of files uploaded in the last backup. Files added are "invisible".

Steps to reproduce

• Run send-backup once to create and upload a baseline backup
• Type echo "test" >/etc/config/test to create a new file
• Run send-backup again

Expected behavior

Backup uploaded.

Actual behavior

send-backup misses the change when the only difference is a newly added file and the new backup is not uploaded.

[filippocarletti]

Possible fix:

diff --git a/packages/ns-plug/files/send-backup b/packages/ns-plug/files/send-backup
index ed1087a5..95810db7 100644
--- a/packages/ns-plug/files/send-backup
+++ b/packages/ns-plug/files/send-backup
@@ -52,9 +52,9 @@ sysupgrade -q -k -b "$BACKUP"
 rm -rf "$EXTRACTED_BACKUP"
 mkdir -p "$EXTRACTED_BACKUP"
 tar -zxf "$BACKUP" -C "$EXTRACTED_BACKUP"
-find "$EXTRACTED_BACKUP" -type f -exec md5sum {} \; > "$MD5"
+find "$EXTRACTED_BACKUP" -type f -exec md5sum {} \; | sort > "$MD5"
 
-# Send backup if there is no md5 saved, or if the md5 changed
-if [ ! -f "$MD5_LAST" ] || ! md5sum -c -s "$MD5_LAST"; then
+# Send backup if there is no md5 saved, or if the md5 list changed
+if [ ! -f "$MD5_LAST" ] || ! cmp -s "$MD5" "$MD5_LAST"; then
     send
 fi

[Tbaile]

With last QA, try again and see if the issue has been addressed.