Skip to content

Commit 1db44ec

Browse files
authored
Use default setuptools-scm tag parsing (#2922)
1 parent 530898e commit 1db44ec

5 files changed

Lines changed: 1 addition & 9 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ version-check failure:
111111
2. **Stale tags** (a fork that has not fetched upstream in a while): you get a
112112
plausible-looking but wrong version, e.g. `13.0.4.dev650+g0d22cb44` when the
113113
real latest tag is `v13.4.2`. Nothing warns you. Note there is no leading
114-
`v` — the tag prefix is stripped by `tag_regex`.
114+
`v` — `setuptools-scm` strips the tag prefix.
115115
3. **No git metadata** (source zip): the build fails with
116116
`LookupError: setuptools-scm was unable to detect version`.
117117

‎cuda_bindings/pyproject.toml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,4 @@ markers = [
104104
[tool.setuptools_scm]
105105
root = ".."
106106
version_file = "cuda/bindings/_version.py"
107-
# Preserve a/b pre-release suffixes, but intentionally strip rc suffixes.
108-
tag_regex = "^(?P<version>v\\d+\\.\\d+\\.\\d+(?:[ab]\\d+)?)"
109107
git_describe_command = ["git", "describe", "--dirty", "--tags", "--long", "--match", "v*[0-9]*"]

‎cuda_core/pyproject.toml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ readme = { file = ["DESCRIPTION.rst"], content-type = "text/x-rst" }
116116
[tool.setuptools_scm]
117117
root = ".."
118118
version_file = "cuda/core/_version.py"
119-
# Preserve a/b pre-release suffixes, but intentionally strip rc suffixes.
120-
tag_regex = "^cuda-core-(?P<version>v\\d+\\.\\d+\\.\\d+(?:[ab]\\d+)?)"
121119
git_describe_command = ["git", "describe", "--dirty", "--tags", "--long", "--match", "cuda-core-v*[0-9]*"]
122120

123121
[tool.mypy]

‎cuda_pathfinder/pyproject.toml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ build-backend = "setuptools.build_meta"
104104
[tool.setuptools_scm]
105105
root = ".."
106106
version_file = "cuda/pathfinder/_version.py"
107-
# Preserve a/b pre-release suffixes, but intentionally strip rc suffixes.
108-
tag_regex = "^cuda-pathfinder-(?P<version>v\\d+\\.\\d+\\.\\d+(?:[ab]\\d+)?)"
109107
git_describe_command = [ "git", "describe", "--dirty", "--tags", "--long", "--match", "cuda-pathfinder-v*[0-9]*" ]
110108

111109
[tool.pytest.ini_options]

‎cuda_python/setup.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
version = get_version(
1212
root="..",
1313
relative_to=__file__,
14-
# Preserve a/b pre-release suffixes, but intentionally strip rc suffixes.
15-
tag_regex="^(?P<version>v\\d+\\.\\d+\\.\\d+(?:[ab]\\d+)?)",
1614
git_describe_command=["git", "describe", "--dirty", "--tags", "--long", "--match", "v*[0-9]*"],
1715
)
1816

0 commit comments

Comments
 (0)